Skip to content

Commit 16da56e

Browse files
committed
improve the confused assert message
1 parent 18eddf7 commit 16da56e

File tree

1 file changed

+21
-18
lines changed

1 file changed

+21
-18
lines changed

src/test/java/org/json/junit/JSONObjectTest.java

Lines changed: 21 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -589,19 +589,19 @@ public void jsonObjectByBean2() {
589589
jsonObject.has("someString"));
590590
assertFalse("Normal field name (myDouble) processing did not work",
591591
jsonObject.has("myDouble"));
592-
assertFalse("Normal field name (someFloat) found",
592+
assertFalse("Normal field name (someFloat) processing did not work",
593593
jsonObject.has("someFloat"));
594-
assertFalse("Ignored field found!",
594+
assertFalse("Ignored field not found!",
595595
jsonObject.has("ignoredInt"));
596-
assertTrue("Normal field name (someInt) processing did not work",
596+
assertTrue("Normal field name (someInt) found",
597597
jsonObject.has("someInt"));
598-
assertTrue("Normal field name (someLong) processing did not work",
598+
assertTrue("Normal field name (someLong) found",
599599
jsonObject.has("someLong"));
600-
assertTrue("Overridden String field name (myStringField) not found",
600+
assertTrue("Overridden String field name (myStringField) found",
601601
jsonObject.has("myStringField"));
602-
assertTrue("Overridden String field name (Some Weird NAme that Normally Wouldn't be possible!) not found",
602+
assertTrue("Overridden String field name (Some Weird NAme that Normally Wouldn't be possible!) found",
603603
jsonObject.has("Some Weird NAme that Normally Wouldn't be possible!"));
604-
assertTrue("Overridden String field name (InterfaceField) not found",
604+
assertTrue("Overridden String field name (InterfaceField) found",
605605
jsonObject.has("InterfaceField"));
606606
}
607607

@@ -619,26 +619,29 @@ public void jsonObjectByBean3() {
619619
jsonObject.has("someInt"));
620620
assertFalse("Normal field name (myDouble) processing did not work",
621621
jsonObject.has("myDouble"));
622-
assertFalse("Overridden String field name (Some Weird NAme that Normally Wouldn't be possible!) FOUND!",
622+
assertFalse("Overridden String field name (Some Weird NAme that Normally Wouldn't be possible!) not FOUND!",
623623
jsonObject.has("Some Weird NAme that Normally Wouldn't be possible!"));
624-
assertFalse("Normal field name (someFloat) found",
624+
assertFalse("Normal field name (someFloat) found, but was overridden",
625625
jsonObject.has("someFloat"));
626-
assertFalse("Ignored field found!",
626+
assertFalse("Ignored field found! but was overridden",
627627
jsonObject.has("ignoredInt"));
628-
assertFalse("Ignored field at the same level as forced name found",
628+
assertFalse("Ignored field at the same level as forced name not found",
629629
jsonObject.has("ShouldBeIgnored"));
630-
assertTrue("Overridden int field name (newIntFieldName) not found",
630+
assertFalse("Normally ignored field (able) with explicit property name not found",
631+
jsonObject.has("able"));
632+
assertTrue("Overridden int field name (newIntFieldName) found",
631633
jsonObject.has("newIntFieldName"));
632-
assertTrue("Normal field name (someLong) processing did not work",
634+
assertTrue("Normal field name (someLong) found",
633635
jsonObject.has("someLong"));
634-
assertTrue("Overridden String field name (myStringField) not found",
636+
assertTrue("Overridden String field name (myStringField) found",
635637
jsonObject.has("myStringField"));
636-
assertTrue(jsonObject.has("AMoreNormalName"));
637-
assertTrue("Overridden String field name (InterfaceField) not found",
638+
assertTrue("Overridden double field name (AMoreNormalName) found",
639+
jsonObject.has("AMoreNormalName"));
640+
assertTrue("Overridden String field name (InterfaceField) found",
638641
jsonObject.has("InterfaceField"));
639-
assertTrue("Forced field not found!",
642+
assertTrue("Forced field found!",
640643
jsonObject.has("forcedInt"));
641-
assertTrue("Normally ignored field (getable) with explicit property name not found",
644+
assertTrue("Overridden boolean field name (Getable) found",
642645
jsonObject.has("Getable"));
643646
}
644647

0 commit comments

Comments
 (0)