refactor: add private prop to identify compted ref

Author: LinusBorg

packages/reactivity/__tests__/readonly.spec.ts

@@ -445,7 +445,11 @@ describe('reactivity/readonly', () => {
     r.value = true
 
     expect(rC.value).toBe(true)
-    ;(rC as any).randomProperty = true
+    expect(
+      'Set operation on key "_dirty" failed: target is readonly.'
+    ).not.toHaveBeenWarned()
+    // @ts-expect-error - non-existant property
+    rC.randomProperty = true
 
     expect(
       'Set operation on key "randomProperty" failed: target is readonly.'

packages/reactivity/src/baseHandlers.ts

@@ -198,8 +198,7 @@ export const mutableHandlers: ProxyHandler<object> = {
 export const readonlyHandlers: ProxyHandler<object> = {
   get: readonlyGet,
   set(target, key, value, receiver) {
-    // is computed()
-    if ((target as any).__v_isRef && (target as any).effect) {
+    if ((target as any).__v_isComputed) {
       // computed should be able to set its own private properties
       if (key === '_dirty' || key === '_value') {
         return set(target, key, value, receiver)

packages/reactivity/src/computed.ts

@@ -26,7 +26,9 @@ class ComputedRefImpl<T> {
 
   public readonly effect: ReactiveEffect<T>
 
-  public readonly __v_isRef = true;
+  public readonly __v_isRef = true
+  // flag to properly handle computed refs in readonly basehandlers
+  public readonly __v_isComputed = true;
   public readonly [ReactiveFlags.IS_READONLY]: boolean
 
   constructor(