File tree Expand file tree Collapse file tree 2 files changed +4
-0
lines changed Expand file tree Collapse file tree 2 files changed +4
-0
lines changed Original file line number Diff line number Diff line change @@ -522,6 +522,7 @@ export function createRouter(options: RouterOptions): Router {
522
522
function locationAsObject (
523
523
to : RouteLocationRaw | RouteLocationNormalized
524
524
) : Exclude < RouteLocationRaw , string > | RouteLocationNormalized {
525
+ // FIXME: does not take into account query params
525
526
return typeof to === 'string' ? { path : to } : assign ( { } , to )
526
527
}
527
528
@@ -586,7 +587,9 @@ export function createRouter(options: RouterOptions): Router {
586
587
}
587
588
588
589
function pushWithRedirect (
590
+ // TODO: should only be RouteLocation?
589
591
to : RouteLocationRaw | RouteLocation ,
592
+ // TODO: add replace here
590
593
redirectedFrom ?: RouteLocation
591
594
) : Promise < NavigationFailure | void | undefined > {
592
595
const targetLocation : RouteLocation = ( pendingLocation = resolve ( to ) )
Original file line number Diff line number Diff line change @@ -27,6 +27,7 @@ export type RouteParamsRaw = Record<
27
27
RouteParamValueRaw | RouteParamValueRaw [ ]
28
28
>
29
29
30
+ // TODO: document, mark as internal and export intermediate types for RouteLocationRaw
30
31
export interface RouteQueryAndHash {
31
32
query ?: LocationQueryRaw
32
33
hash ?: string
You can’t perform that action at this time.
0 commit comments