make v-model checkbox replace array instead of mutating it

yyx990803 · yyx990803 · commit 9c4bf3590b3f · 2016-07-22T13:21:05.000-04:00
diff --git a/src/platforms/web/compiler/directives/model.js b/src/platforms/web/compiler/directives/model.js
@@ -52,8 +52,8 @@ function genCheckboxModel (el: ASTElement, value: ?string) {
     'if(Array.isArray($$a)){' +
       `var $$v=${valueBinding},` +
           '$$i=$$a.indexOf($$v);' +
-      'if($$c){$$i<0&&$$a.push($$v)}' +
-      'else{$$i>-1&&$$a.splice($$i,1)}' +
+      `if($$c){$$i<0&&(${value}=$$a.concat($$v))}` +
+      `else{$$i>-1&&(${value}=$$a.slice(0,$$i).concat($$a.slice($$i+1)))}` +
     `}else{${value}=$$c}`
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ function genCheckboxModel (el: ASTElement, value: ?string) {`
`52`	`52`	`'if(Array.isArray($$a)){' +`
`53`	`53`	`var $$v=${valueBinding},` +
`54`	`54`	`'$$i=$$a.indexOf($$v);' +`
`55`		`- 'if($$c){$$i<0&&$$a.push($$v)}' +`
`56`		`- 'else{$$i>-1&&$$a.splice($$i,1)}' +`
	`55`	+ `if($$c){$$i<0&&(${value}=$$a.concat($$v))}` +
	`56`	+ `else{$$i>-1&&(${value}=$$a.slice(0,$$i).concat($$a.slice($$i+1)))}` +
`57`	`57`	`}else{${value}=$$c}`
`58`	`58`	`)`
`59`	`59`	`}`