Skip to content

Commit 4d87fff

Browse files
committed
include loc in snapshots
1 parent 189b647 commit 4d87fff

File tree

1 file changed

+16
-39
lines changed

1 file changed

+16
-39
lines changed

test/Errors.test.js

Lines changed: 16 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -19,32 +19,10 @@ function cleanError(err) {
1919
result.message = err.message.replace(ERROR_STACK_PATTERN, "");
2020
}
2121

22-
if (result.loc) {
23-
result.loc = "<muted>";
24-
}
25-
2622
if (result.stack) {
2723
result.stack = result.stack.replace(ERROR_STACK_PATTERN, "");
2824
}
2925

30-
if (Array.isArray(result.moduleTrace)) {
31-
result.moduleTrace = result.moduleTrace.map(record => {
32-
if (record.dependencies) {
33-
return Object.assign(record, {
34-
dependencies: record.dependencies.map(dep => {
35-
if (dep.loc) {
36-
return Object.assign(dep, {
37-
loc: "<muted>"
38-
});
39-
}
40-
41-
return dep;
42-
})
43-
});
44-
}
45-
});
46-
}
47-
4826
return result;
4927
}
5028

@@ -66,8 +44,7 @@ const prettyFormatOptions = {
6644
return `"${val
6745
.replace(/\\/gm, "/")
6846
.replace(/"/gm, '\\"')
69-
.replace(/\n/gm, "\\n")
70-
}"`;
47+
.replace(/\n/gm, "\\n")}"`;
7148
}
7249
}
7350
]
@@ -160,15 +137,15 @@ it("should emit warning for missingFile", async () => {
160137
Object {
161138
"errors": Array [
162139
Object {
163-
"loc": "<muted>",
140+
"loc": "4:0-20",
164141
"message": "Module not found: Error: Can't resolve './missing' in '<cwd>/test/fixtures/errors'",
165142
"moduleId": 0,
166143
"moduleIdentifier": "<cwd>/test/fixtures/errors/missingFile.js",
167144
"moduleName": "./missingFile.js",
168145
"moduleTrace": Array [],
169146
},
170147
Object {
171-
"loc": "<muted>",
148+
"loc": "12:9-34",
172149
"message": "Module not found: Error: Can't resolve './dir/missing2' in '<cwd>/test/fixtures/errors'",
173150
"moduleId": 0,
174151
"moduleIdentifier": "<cwd>/test/fixtures/errors/missingFile.js",
@@ -188,7 +165,7 @@ Object {
188165
"errors": Array [],
189166
"warnings": Array [
190167
Object {
191-
"loc": "<muted>",
168+
"loc": "1:0-18",
192169
"message": "require.extensions is not supported by webpack. Use a loader instead.",
193170
"moduleId": 0,
194171
"moduleIdentifier": "<cwd>/test/fixtures/errors/require.extensions.js",
@@ -207,7 +184,7 @@ Object {
207184
"errors": Array [],
208185
"warnings": Array [
209186
Object {
210-
"loc": "<muted>",
187+
"loc": "1:0-20",
211188
"message": "require.main.require is not supported by webpack.",
212189
"moduleId": 0,
213190
"moduleIdentifier": "<cwd>/test/fixtures/errors/require.main.require.js",
@@ -225,7 +202,7 @@ Object {
225202
"errors": Array [],
226203
"warnings": Array [
227204
Object {
228-
"loc": "<muted>",
205+
"loc": "1:0-21",
229206
"message": "module.parent.require is not supported by webpack.",
230207
"moduleId": 0,
231208
"moduleIdentifier": "<cwd>/test/fixtures/errors/module.parent.require.js",
@@ -237,10 +214,10 @@ Object {
237214
`);
238215
});
239216

240-
const isCasePreservedFilesystem = fs.existsSync(
217+
const isCaseInsensitiveFilesystem = fs.existsSync(
241218
path.resolve(__dirname, "fixtures", "errors", "FILE.js")
242219
);
243-
if (isCasePreservedFilesystem) {
220+
if (isCaseInsensitiveFilesystem) {
244221
it("should emit warning for case-preserved disk", async () => {
245222
const result = await compile({
246223
mode: "development",
@@ -259,7 +236,7 @@ Object {
259236
Object {
260237
"dependencies": Array [
261238
Object {
262-
"loc": "<muted>",
239+
"loc": "2:0-17",
263240
},
264241
],
265242
"moduleId": "./FILE.js",
@@ -285,7 +262,7 @@ Object {
285262
Object {
286263
"errors": Array [
287264
Object {
288-
"loc": "<muted>",
265+
"loc": "2:0-17",
289266
"message": "Module not found: Error: Can't resolve './FILE' in '<cwd>/test/fixtures/errors'",
290267
"moduleId": "./case-sensitive.js",
291268
"moduleIdentifier": "<cwd>/test/fixtures/errors/case-sensitive.js",
@@ -328,15 +305,15 @@ it("should emit errors for missingFile for production", async () => {
328305
Object {
329306
"errors": Array [
330307
Object {
331-
"loc": "<muted>",
308+
"loc": "4:0-20",
332309
"message": "Module not found: Error: Can't resolve './missing' in '<cwd>/test/fixtures/errors'",
333310
"moduleId": 665,
334311
"moduleIdentifier": "<cwd>/test/fixtures/errors/missingFile.js",
335312
"moduleName": "./missingFile.js",
336313
"moduleTrace": Array [],
337314
},
338315
Object {
339-
"loc": "<muted>",
316+
"loc": "12:9-34",
340317
"message": "Module not found: Error: Can't resolve './dir/missing2' in '<cwd>/test/fixtures/errors'",
341318
"moduleId": 665,
342319
"moduleIdentifier": "<cwd>/test/fixtures/errors/missingFile.js",
@@ -355,7 +332,7 @@ it("should emit module build errors", async () => {
355332
Object {
356333
"errors": Array [
357334
Object {
358-
"loc": "<muted>",
335+
"loc": "2:12",
359336
"message": "Module parse failed: Unexpected token (2:12)\\nYou may need an appropriate loader to handle this file type.\\n| window.foo = {\\n> bar: true,;\\n| };\\n| ",
360337
"moduleId": 0,
361338
"moduleIdentifier": "<cwd>/test/fixtures/errors/has-syntax-error.js",
@@ -417,7 +394,7 @@ Object {
417394
Object {
418395
"dependencies": Array [
419396
Object {
420-
"loc": "<muted>",
397+
"loc": "1:0-40",
421398
},
422399
],
423400
"moduleId": 1,
@@ -440,7 +417,7 @@ Object {
440417
Object {
441418
"dependencies": Array [
442419
Object {
443-
"loc": "<muted>",
420+
"loc": "1:0-40",
444421
},
445422
],
446423
"moduleId": 1,
@@ -643,7 +620,7 @@ Object {
643620
Object {
644621
"errors": Array [
645622
Object {
646-
"loc": "<muted>",
623+
"loc": "main",
647624
"message": "Module not found: Error: Can't resolve './doesnt-exist-loader' in '<cwd>/test/fixtures/errors'",
648625
},
649626
],

0 commit comments

Comments
 (0)