Merge pull request webpack#7750 from ak-14/node-dependencies

Handle module.require, require.main.require, and module.parent.require

Author: sokra

lib/NodeStuffPlugin.js

@@ -108,6 +108,24 @@ class NodeStuffPlugin {
 								"require.extensions is not supported by webpack. Use a loader instead."
 							)
 						);
+					parser.hooks.expression
+						.for("require.main.require")
+						.tap(
+							"NodeStuffPlugin",
+							ParserHelpers.expressionIsUnsupported(
+								parser,
+								"require.main.require is not supported by webpack."
+							)
+						);
+					parser.hooks.expression
+						.for("module.parent.require")
+						.tap(
+							"NodeStuffPlugin",
+							ParserHelpers.expressionIsUnsupported(
+								parser,
+								"module.parent.require is not supported by webpack."
+							)
+						);
 					parser.hooks.expression
 						.for("module.loaded")
 						.tap("NodeStuffPlugin", expr => {

lib/dependencies/CommonJsRequireDependencyParserPlugin.js

@@ -125,6 +125,12 @@ class CommonJsRequireDependencyParserPlugin {
 		parser.hooks.new
 			.for("require")
 			.tap("CommonJsRequireDependencyParserPlugin", createHandler(true));
+		parser.hooks.call
+			.for("module.require")
+			.tap("CommonJsRequireDependencyParserPlugin", createHandler(false));
+		parser.hooks.new
+			.for("module.require")
+			.tap("CommonJsRequireDependencyParserPlugin", createHandler(true));
 	}
 }
 module.exports = CommonJsRequireDependencyParserPlugin;

test/Errors.test.js

@@ -94,6 +94,42 @@ describe("Errors", () => {
 			}
 		);
 	});
+	it("should report require.main.require as unsupported", done => {
+		getErrors(
+			{
+				mode: "development",
+				entry: "./require.main.require"
+			},
+			(errors, warnings) => {
+				expect(errors).toHaveLength(0);
+				expect(warnings).toHaveLength(1);
+				const lines = warnings[0].split("\n");
+				expect(lines[0]).toMatch(/require.main.require\.js/);
+				expect(lines[1]).toMatch(
+					/require.main.require is not supported by webpack/
+				);
+				done();
+			}
+		);
+	});
+	it("should report module.parent.require as unsupported", done => {
+		getErrors(
+			{
+				mode: "development",
+				entry: "./module.parent.require"
+			},
+			(errors, warnings) => {
+				expect(errors).toHaveLength(0);
+				expect(warnings).toHaveLength(1);
+				const lines = warnings[0].split("\n");
+				expect(lines[0]).toMatch(/module.parent.require\.js/);
+				expect(lines[1]).toMatch(
+					/module.parent.require is not supported by webpack/
+				);
+				done();
+			}
+		);
+	});
 	it("should warn about case-sensitive module names", done => {
 		getErrors(
 			{

test/cases/parsing/issue-7728/a.js

@@ -0,0 +1,3 @@
+export default function test() {
+  return "OK";
+}

test/cases/parsing/issue-7728/index.js

@@ -0,0 +1,4 @@
+it("should detect module.require dependency", function () {
+	var test1 = module.require('./a').default;
+	expect(test1()).toBe("OK");
+});

test/fixtures/errors/module.parent.require.js

@@ -0,0 +1 @@
+module.parent.require('./file');

test/fixtures/errors/require.main.require.js

@@ -0,0 +1 @@
+require.main.require('./file');