fixup WebpackErrors

Author: sokra

lib/CommentCompilationWarning.js

@@ -29,26 +29,6 @@ class CommentCompilationWarning extends WebpackError {
 
 		Error.captureStackTrace(this, this.constructor);
 	}
-
-	serialize(context) {
-		const { write } = context;
-
-		write(this.name);
-		write(this.module);
-		write(this.loc);
-
-		super.serialize(context);
-	}
-
-	deserialize(context) {
-		const { read } = context;
-
-		this.name = read();
-		this.module = read();
-		this.loc = read();
-
-		super.serialize(context);
-	}
 }
 
 makeSerializable(

lib/ModuleBuildError.js

@@ -57,9 +57,6 @@ class ModuleBuildError extends WebpackError {
 	serialize(context) {
 		const { write } = context;
 
-		write(this.name);
-		write(this.details);
-		write(this.module);
 		write(this.error);
 
 		super.serialize(context);
@@ -68,9 +65,6 @@ class ModuleBuildError extends WebpackError {
 	deserialize(context) {
 		const { read } = context;
 
-		this.name = read();
-		this.details = read();
-		this.module = read();
 		this.error = read();
 
 		super.deserialize(context);

lib/ModuleError.js

@@ -41,21 +41,15 @@ class ModuleError extends WebpackError {
 	serialize(context) {
 		const { write } = context;
 
-		write(this.name);
-		write(this.module);
 		write(this.error);
-		write(this.details);
 
 		super.serialize(context);
 	}
 
 	deserialize(context) {
 		const { read } = context;
 
-		this.name = read();
-		this.module = read();
 		this.error = read();
-		this.details = read();
 
 		super.deserialize(context);
 	}

lib/ModuleParseError.js

@@ -63,9 +63,6 @@ class ModuleParseError extends WebpackError {
 	serialize(context) {
 		const { write } = context;
 
-		write(this.name);
-		write(this.module);
-		write(this.loc);
 		write(this.error);
 
 		super.serialize(context);
@@ -74,15 +71,12 @@ class ModuleParseError extends WebpackError {
 	deserialize(context) {
 		const { read } = context;
 
-		this.name = read();
-		this.module = read();
-		this.loc = read();
 		this.error = read();
 
 		super.deserialize(context);
 	}
 }
 
-makeSerializable(ModuleParseError, "webpack/lib/dependencies/ModuleParseError");
+makeSerializable(ModuleParseError, "webpack/lib/ModuleParseError");
 
 module.exports = ModuleParseError;

lib/ModuleWarning.js

@@ -41,21 +41,15 @@ class ModuleWarning extends WebpackError {
 	serialize(context) {
 		const { write } = context;
 
-		write(this.name);
-		write(this.module);
 		write(this.warning);
-		write(this.details);
 
 		super.serialize(context);
 	}
 
 	deserialize(context) {
 		const { read } = context;
 
-		this.name = read();
-		this.module = read();
 		this.warning = read();
-		this.details = read();
 
 		super.deserialize(context);
 	}

lib/NormalModule.js

@@ -39,7 +39,6 @@ const makeSerializable = require("./util/makeSerializable");
 /** @typedef {import("./Module").SourceContext} SourceContext */
 /** @typedef {import("./RequestShortener")} RequestShortener */
 /** @typedef {import("./RuntimeTemplate")} RuntimeTemplate */
-/** @typedef {import("./WebpackError")} WebpackError */
 /** @typedef {import("./util/createHash").Hash} Hash */
 
 const EARLY_RETURN_ERROR = new Error("flags early return is not an error");
@@ -69,6 +68,12 @@ class NonErrorEmittedError extends WebpackError {
 	}
 }
 
+makeSerializable(
+	NonErrorEmittedError,
+	"webpack/lib/NormalModule",
+	"NonErrorEmittedError"
+);
+
 /**
  * @typedef {Object} CachedSourceEntry
  * @property {TODO} source the generated source

lib/UnsupportedFeatureWarning.js

@@ -27,28 +27,6 @@ class UnsupportedFeatureWarning extends WebpackError {
 
 		Error.captureStackTrace(this, this.constructor);
 	}
-
-	serialize(context) {
-		const { write } = context;
-
-		write(this.name);
-		write(this.module);
-		write(this.loc);
-		write(this.hideStack);
-
-		super.serialize(context);
-	}
-
-	deserialize(context) {
-		const { read } = context;
-
-		this.name = read();
-		this.module = read();
-		this.loc = read();
-		this.hideStack = read();
-
-		super.deserialize(context);
-	}
 }
 
 makeSerializable(

lib/WebpackError.js

@@ -22,6 +22,8 @@ class WebpackError extends Error {
 		this.module = undefined;
 		/** @type {DependencyLocation} */
 		this.loc = undefined;
+		/** @type {boolean} */
+		this.hideStack = undefined;
 
 		Error.captureStackTrace(this, this.constructor);
 	}
@@ -30,26 +32,24 @@ class WebpackError extends Error {
 		return this.stack + (this.details ? `\n${this.details}` : "");
 	}
 
-	serialize(context) {
-		const { write } = context;
-
+	serialize({ write }) {
+		write(this.name);
+		write(this.message);
+		write(this.stack);
 		write(this.details);
 		write(this.missing);
-		write(this.module);
 		write(this.loc);
-
-		super.serialize(context);
+		write(this.hideStack);
 	}
 
-	deserialize(context) {
-		const { read } = context;
-
+	deserialize({ read }) {
+		this.name = read();
+		this.message = read();
+		this.stack = read();
 		this.details = read();
 		this.missing = read();
-		this.module = read();
 		this.loc = read();
-
-		super.deserialize(context);
+		this.hideStack = read();
 	}
 }
 

lib/dependencies/CriticalDependencyWarning.js

@@ -6,6 +6,7 @@
 "use strict";
 
 const WebpackError = require("../WebpackError");
+const makeSerializable = require("../util/makeSerializable");
 
 class CriticalDependencyWarning extends WebpackError {
 	constructor(message) {
@@ -18,4 +19,9 @@ class CriticalDependencyWarning extends WebpackError {
 	}
 }
 
+makeSerializable(
+	CriticalDependencyWarning,
+	"webpack/lib/dependencies/CriticalDependencyWarning"
+);
+
 module.exports = CriticalDependencyWarning;