Merge pull request webpack#8680 from wtgtybhertgeghgtwtg/fast-stable-stringify

Replace `json-stable-stringify` with `fast-json-stable-stringify`.

Author: sokra

lib/Compiler.js

@@ -6,7 +6,6 @@
 "use strict";
 
 const parseJson = require("json-parse-better-errors");
-const stringify = require("json-stable-stringify");
 const asyncLib = require("neo-async");
 const path = require("path");
 const {
@@ -58,6 +57,29 @@ const { makePathsRelative } = require("./util/identifier");
  * @param {Compilation=} compilation
  */
 
+/**
+ * @param {string[]} array an array
+ * @returns {boolean} true, if the array is sorted
+ */
+const isSorted = array => {
+	for (let i = 1; i < array.length; i++) {
+		if (array[i - 1] > array[i]) return false;
+	}
+	return true;
+};
+
+/**
+ * @param {Object} obj an object
+ * @param {string[]} keys the keys of the object
+ * @returns {Object} the object with properties sorted by property name
+ */
+const sortObject = (obj, keys) => {
+	return keys.sort().reduce((o, k) => {
+		o[k] = obj[k];
+		return o;
+	}, {});
+};
+
 class Compiler {
 	/**
 	 * @param {string} context the compilation path
@@ -448,7 +470,23 @@ class Compiler {
 		const writeFile = () => {
 			this.outputFileSystem.writeFile(
 				this.recordsOutputPath,
-				stringify(this.records, { space: 2 }),
+				JSON.stringify(
+					this.records,
+					(n, value) => {
+						if (
+							typeof value === "object" &&
+							value !== null &&
+							!Array.isArray(value)
+						) {
+							const keys = Object.keys(value);
+							if (!isSorted(keys)) {
+								return sortObject(value, keys);
+							}
+						}
+						return value;
+					},
+					2
+				),
 				callback
 			);
 		};

package.json

@@ -18,7 +18,6 @@
     "eslint-scope": "^4.0.0",
     "events": "^3.0.0",
     "json-parse-better-errors": "^1.0.2",
-    "json-stable-stringify": "^1.0.1",
     "loader-runner": "3.0.0",
     "loader-utils": "^1.1.0",
     "memory-fs": "~0.4.1",

test/__snapshots__/ConfigTestCases.test.js.snap

@@ -6,8 +6,7 @@ exports[`ConfigTestCases records issue-2991 exported tests should write relative
     \\"byName\\": {
       \\"main\\": 404
     },
-    \\"bySource\\": {
-    },
+    \\"bySource\\": {},
     \\"usedIds\\": [
       404
     ]
@@ -35,8 +34,7 @@ exports[`ConfigTestCases records issue-7339 exported tests should write relative
     \\"byName\\": {
       \\"main\\": 404
     },
-    \\"bySource\\": {
-    },
+    \\"bySource\\": {},
     \\"usedIds\\": [
       404
     ]