Skip to content

Commit b32a4f5

Browse files
authored
Merge branch 'master' into bugfix/max-size-reasons
2 parents 9362a65 + f95d0f0 commit b32a4f5

File tree

6 files changed

+89
-59
lines changed

6 files changed

+89
-59
lines changed

declarations.d.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ declare namespace NodeJS {
77
}
88
}
99

10-
1110
declare module "neo-async" {
1211
export interface Dictionary<T> {
1312
[key: string]: T;

lib/ContextModule.js

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,28 @@ const contextify = require("./util/identifier").contextify;
1212

1313
/** @typedef {import("./dependencies/ContextElementDependency")} ContextElementDependency */
1414

15+
/**
16+
* @callback ResolveDependenciesCallback
17+
* @param {Error=} err
18+
* @param {ContextElementDependency[]} dependencies
19+
*/
20+
21+
/**
22+
* @callback ResolveDependencies
23+
* @param {TODO} fs
24+
* @param {TODO} options
25+
* @param {ResolveDependenciesCallback} callback
26+
*/
27+
1528
class ContextModule extends Module {
1629
// type ContextMode = "sync" | "eager" | "weak" | "async-weak" | "lazy" | "lazy-once"
1730
// type ContextOptions = { resource: string, recursive: boolean, regExp: RegExp, addon?: string, mode?: ContextMode, chunkName?: string, include?: RegExp, exclude?: RegExp, groupOptions?: Object }
1831
// resolveDependencies: (fs: FS, options: ContextOptions, (err: Error?, dependencies: Dependency[]) => void) => void
1932
// options: ContextOptions
33+
/**
34+
* @param {ResolveDependencies} resolveDependencies function to get dependencies in this context
35+
* @param {TODO} options options object
36+
*/
2037
constructor(resolveDependencies, options) {
2138
let resource;
2239
let resourceQuery;
@@ -194,7 +211,9 @@ class ContextModule extends Module {
194211

195212
// enhance dependencies with meta info
196213
for (const dep of dependencies) {
197-
dep.loc = dep.userRequest;
214+
dep.loc = {
215+
name: dep.userRequest
216+
};
198217
dep.request = this.options.addon + dep.request;
199218
}
200219

lib/DelegatedModuleFactoryPlugin.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ class DelegatedModuleFactoryPlugin {
1515
constructor(options) {
1616
this.options = options;
1717
options.type = options.type || "require";
18-
options.extensions = options.extensions || ["", ".js"];
18+
options.extensions = options.extensions || [
19+
"",
20+
".wasm",
21+
".mjs",
22+
".js",
23+
".json"
24+
];
1925
}
2026

2127
apply(normalModuleFactory) {

lib/Dependency.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ const DependencyReference = require("./dependencies/DependencyReference");
3030

3131
/** @typedef {Object} SynteticDependencyLocation
3232
* @property {string} name
33-
* @property {number} index
33+
* @property {number=} index
3434
*/
3535

3636
/** @typedef {SynteticDependencyLocation|RealDependencyLocation} DependencyLocation */

lib/Stats.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ const optionsOrFallback = (...args) => {
1515
return optionValues.find(optionValue => typeof optionValue !== "undefined");
1616
};
1717

18+
const compareId = (a, b) => {
19+
if (a < b) return -1;
20+
if (a > b) return 1;
21+
return 0;
22+
};
23+
1824
class Stats {
1925
constructor(compilation) {
2026
this.compilation = compilation;
@@ -543,7 +549,7 @@ class Stats {
543549
}
544550
return obj;
545551
})
546-
.sort((a, b) => a.moduleId - b.moduleId);
552+
.sort(compareId);
547553
}
548554
if (showUsedExports) {
549555
if (module.used === true) {
@@ -614,9 +620,9 @@ class Stats {
614620
names: chunk.name ? [chunk.name] : [],
615621
files: chunk.files.slice(),
616622
hash: chunk.renderedHash,
617-
siblings: Array.from(siblings).sort(),
618-
parents: Array.from(parents).sort(),
619-
children: Array.from(children).sort(),
623+
siblings: Array.from(siblings).sort(compareId),
624+
parents: Array.from(parents).sort(compareId),
625+
children: Array.from(children).sort(compareId),
620626
childrenByOrder: childIdByOrder
621627
};
622628
if (showChunkModules) {

0 commit comments

Comments
 (0)