Added chunkFilenameDelimiter option for SplitChunksPlugin: Applied requested changes

Author: ManuelBauer

lib/WebpackOptionsDefaulter.js

@@ -210,7 +210,7 @@ class WebpackOptionsDefaulter extends OptionsDefaulter {
 		this.set("optimization.splitChunks.minSize", 30000);
 		this.set("optimization.splitChunks.minChunks", 1);
 		this.set("optimization.splitChunks.maxAsyncRequests", 5);
-		this.set("optimization.splitChunks.chunkFilenameDelimiter", "~");
+		this.set("optimization.splitChunks.automaticNameDelimiter", "~");
 		this.set("optimization.splitChunks.maxInitialRequests", 3);
 		this.set("optimization.splitChunks.name", true);
 		this.set("optimization.splitChunks.cacheGroups", {});

lib/optimize/SplitChunksPlugin.js

@@ -84,8 +84,6 @@ module.exports = class SplitChunksPlugin {
 	}
 
 	static normalizeOptions(options = {}) {
-		const chunkFilenameDelimiter = options.chunkFilenameDelimiter || "~";
-
 		return {
 			chunks: options.chunks || "all",
 			minSize: options.minSize || 0,
@@ -94,51 +92,50 @@ module.exports = class SplitChunksPlugin {
 			maxInitialRequests: options.maxInitialRequests || 1,
 			getName:
 				SplitChunksPlugin.normalizeName({
-					option: options.name,
-					chunkFilenameDelimiter
+					name: options.name,
+					automaticNameDelimiter: options.automaticNameDelimiter
 				}) || (() => {}),
 			filename: options.filename || undefined,
 			getCacheGroups: SplitChunksPlugin.normalizeCacheGroups({
 				cacheGroups: options.cacheGroups,
-				chunkFilenameDelimiter
-			}),
-			chunkFilenameDelimiter: chunkFilenameDelimiter
+				automaticNameDelimiter: options.automaticNameDelimiter
+			})
 		};
 	}
 
-	static normalizeName({ option, chunkFilenameDelimiter }) {
-		if (option === true) {
+	static normalizeName({ name, automaticNameDelimiter }) {
+		if (name === true) {
 			const fn = (module, chunks, cacheGroup) => {
 				const names = chunks.map(c => c.name);
 				if (!names.every(Boolean)) return;
 				names.sort();
 				let name =
 					(cacheGroup && cacheGroup !== "default"
-						? cacheGroup + chunkFilenameDelimiter
-						: "") + names.join(chunkFilenameDelimiter);
+						? cacheGroup + automaticNameDelimiter
+						: "") + names.join(automaticNameDelimiter);
 				// Filenames and paths can't be too long otherwise an
 				// ENAMETOOLONG error is raised. If the generated name if too
 				// long, it is truncated and a hash is appended. The limit has
 				// been set to 100 to prevent `[name].[chunkhash].[ext]` from
 				// generating a 256+ character string.
 				if (name.length > 100) {
 					name =
-						name.slice(0, 100) + chunkFilenameDelimiter + hashFilename(name);
+						name.slice(0, 100) + automaticNameDelimiter + hashFilename(name);
 				}
 				return name;
 			};
 			return fn;
 		}
 		if (typeof option === "string") {
 			const fn = () => {
-				return option;
+				return name;
 			};
 			return fn;
 		}
-		if (typeof option === "function") return option;
+		if (typeof option === "function") return name;
 	}
 
-	static normalizeCacheGroups({ cacheGroups, chunkFilenameDelimiter }) {
+	static normalizeCacheGroups({ cacheGroups, automaticNameDelimiter }) {
 		if (typeof cacheGroups === "function") {
 			return cacheGroups;
 		}
@@ -174,8 +171,8 @@ module.exports = class SplitChunksPlugin {
 							key: key,
 							priority: option.priority,
 							getName: SplitChunksPlugin.normalizeName({
-								option: option.name,
-								chunkFilenameDelimiter
+								name: option.name,
+								automaticNameDelimiter
 							}),
 							chunks: option.chunks,
 							enforce: option.enforce,

schemas/WebpackOptions.json

@@ -1382,8 +1382,8 @@
                   "type": "string",
                   "minLength": 1
                 },
-                "chunkFilenameDelimiter": {
-                  "description": "Sets the filename delimiter for created chunks",
+                "automaticNameDelimiter": {
+                  "description": "Sets the name delimiter for created chunks",
                   "type": "string",
                   "minLength": 1
                 },