fix(scroll): avoid reusing scroll position

posva · posva · commit dfc1fb34a761 · 2020-05-24T16:33:33.000+02:00
diff --git a/src/router.ts b/src/router.ts
@@ -652,6 +652,7 @@ export function createRouter(options: RouterOptions): Router {
     pendingLocation = toLocation
     const from = currentRoute.value
 
+    // TODO: should be moved to web history?
     if (isBrowser) {
       saveScrollPosition(
         getScrollKey(from.fullPath, info.delta),
diff --git a/src/scrollBehavior.ts b/src/scrollBehavior.ts
@@ -123,7 +123,10 @@ export function saveScrollPosition(
 }
 
 export function getSavedScrollPosition(key: string) {
-  return scrollPositions.get(key)
+  const scroll = scrollPositions.get(key)
+  // consume it so it's not used again
+  scrollPositions.delete(key)
+  return scroll
 }
 
 // TODO: RFC about how to save scroll position

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,10 @@ export function saveScrollPosition(`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`export function getSavedScrollPosition(key: string) {`
`126`		`- return scrollPositions.get(key)`
	`126`	`+ const scroll = scrollPositions.get(key)`
	`127`	`+ // consume it so it's not used again`
	`128`	`+ scrollPositions.delete(key)`
	`129`	`+ return scroll`
`127`	`130`	`}`
`128`	`131`
`129`	`132`	`// TODO: RFC about how to save scroll position`