test(html-button-has-type): make tests more strict (#2831)

ST-DDT · web-flow · commit a8c09404edd7 · 2025-07-25T19:05:48.000+02:00
diff --git a/tests/lib/rules/html-button-has-type.js b/tests/lib/rules/html-button-has-type.js
@@ -58,7 +58,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'Missing an explicit type attribute for button.',
-          column: 11
+          column: 11,
+          line: 1,
+          endLine: 1,
+          endColumn: 19
         }
       ]
     },
@@ -68,7 +71,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'A value must be set for button type attribute.',
-          column: 24
+          column: 24,
+          line: 1,
+          endLine: 1,
+          endColumn: 26
         }
       ]
     },
@@ -78,7 +84,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'A value must be set for button type attribute.',
-          column: 19
+          column: 19,
+          line: 1,
+          endLine: 1,
+          endColumn: 23
         }
       ]
     },
@@ -88,7 +97,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'foo is an invalid value for button type attribute.',
-          column: 24
+          column: 24,
+          line: 1,
+          endLine: 1,
+          endColumn: 29
         }
       ]
     },
@@ -99,7 +111,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'button is a forbidden value for button type attribute.',
-          column: 24
+          column: 24,
+          line: 1,
+          endLine: 1,
+          endColumn: 32
         }
       ]
     },
@@ -110,7 +125,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'submit is a forbidden value for button type attribute.',
-          column: 24
+          column: 24,
+          line: 1,
+          endLine: 1,
+          endColumn: 32
         }
       ]
     },
@@ -121,7 +139,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'reset is a forbidden value for button type attribute.',
-          column: 24
+          column: 24,
+          line: 1,
+          endLine: 1,
+          endColumn: 31
         }
       ]
     },
@@ -137,17 +158,23 @@ ruleTester.run('html-button-has-type', rule, {
         {
           message: 'button is a forbidden value for button type attribute.',
           line: 2,
-          column: 30
+          column: 30,
+          endLine: 2,
+          endColumn: 38
         },
         {
           message: 'submit is a forbidden value for button type attribute.',
           line: 3,
-          column: 30
+          column: 30,
+          endLine: 3,
+          endColumn: 38
         },
         {
           message: 'reset is a forbidden value for button type attribute.',
           line: 4,
-          column: 30
+          column: 30,
+          endLine: 4,
+          endColumn: 37
         }
       ]
     },
@@ -165,17 +192,23 @@ ruleTester.run('html-button-has-type', rule, {
         {
           message: 'reset is a forbidden value for button type attribute.',
           line: 4,
-          column: 30
+          column: 30,
+          endLine: 4,
+          endColumn: 37
         },
         {
           message: 'A value must be set for button type attribute.',
           line: 5,
-          column: 30
+          column: 30,
+          endLine: 5,
+          endColumn: 32
         },
         {
           message: 'foo is an invalid value for button type attribute.',
           line: 6,
-          column: 30
+          column: 30,
+          endLine: 6,
+          endColumn: 35
         }
       ]
     },
@@ -185,11 +218,17 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'Missing an explicit type attribute for button.',
-          column: 11
+          column: 11,
+          line: 1,
+          endLine: 1,
+          endColumn: 19
         },
         {
           message: 'Missing an explicit type attribute for button.',
-          column: 39
+          column: 39,
+          line: 1,
+          endLine: 1,
+          endColumn: 47
         }
       ]
     },
@@ -199,7 +238,10 @@ ruleTester.run('html-button-has-type', rule, {
       errors: [
         {
           message: 'A value must be set for button type attribute.',
-          column: 25
+          column: 25,
+          line: 1,
+          endLine: 1,
+          endColumn: 27
         }
       ]
     }

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,10 @@ ruleTester.run('html-button-has-type', rule, {`
`58`	`58`	`errors: [`
`59`	`59`	`{`
`60`	`60`	`message: 'Missing an explicit type attribute for button.',`
`61`		`- column: 11`
	`61`	`+ column: 11,`
	`62`	`+ line: 1,`
	`63`	`+ endLine: 1,`
	`64`	`+ endColumn: 19`
`62`	`65`	`}`
`63`	`66`	`]`
`64`	`67`	`},`
`@@ -68,7 +71,10 @@ ruleTester.run('html-button-has-type', rule, {`
`68`	`71`	`errors: [`
`69`	`72`	`{`
`70`	`73`	`message: 'A value must be set for button type attribute.',`
`71`		`- column: 24`
	`74`	`+ column: 24,`
	`75`	`+ line: 1,`
	`76`	`+ endLine: 1,`
	`77`	`+ endColumn: 26`
`72`	`78`	`}`
`73`	`79`	`]`
`74`	`80`	`},`
`@@ -78,7 +84,10 @@ ruleTester.run('html-button-has-type', rule, {`
`78`	`84`	`errors: [`
`79`	`85`	`{`
`80`	`86`	`message: 'A value must be set for button type attribute.',`
`81`		`- column: 19`
	`87`	`+ column: 19,`
	`88`	`+ line: 1,`
	`89`	`+ endLine: 1,`
	`90`	`+ endColumn: 23`
`82`	`91`	`}`
`83`	`92`	`]`
`84`	`93`	`},`
`@@ -88,7 +97,10 @@ ruleTester.run('html-button-has-type', rule, {`
`88`	`97`	`errors: [`
`89`	`98`	`{`
`90`	`99`	`message: 'foo is an invalid value for button type attribute.',`
`91`		`- column: 24`
	`100`	`+ column: 24,`
	`101`	`+ line: 1,`
	`102`	`+ endLine: 1,`
	`103`	`+ endColumn: 29`
`92`	`104`	`}`
`93`	`105`	`]`
`94`	`106`	`},`
`@@ -99,7 +111,10 @@ ruleTester.run('html-button-has-type', rule, {`
`99`	`111`	`errors: [`
`100`	`112`	`{`
`101`	`113`	`message: 'button is a forbidden value for button type attribute.',`
`102`		`- column: 24`
	`114`	`+ column: 24,`
	`115`	`+ line: 1,`
	`116`	`+ endLine: 1,`
	`117`	`+ endColumn: 32`
`103`	`118`	`}`
`104`	`119`	`]`
`105`	`120`	`},`
`@@ -110,7 +125,10 @@ ruleTester.run('html-button-has-type', rule, {`
`110`	`125`	`errors: [`
`111`	`126`	`{`
`112`	`127`	`message: 'submit is a forbidden value for button type attribute.',`
`113`		`- column: 24`
	`128`	`+ column: 24,`
	`129`	`+ line: 1,`
	`130`	`+ endLine: 1,`
	`131`	`+ endColumn: 32`
`114`	`132`	`}`
`115`	`133`	`]`
`116`	`134`	`},`
`@@ -121,7 +139,10 @@ ruleTester.run('html-button-has-type', rule, {`
`121`	`139`	`errors: [`
`122`	`140`	`{`
`123`	`141`	`message: 'reset is a forbidden value for button type attribute.',`
`124`		`- column: 24`
	`142`	`+ column: 24,`
	`143`	`+ line: 1,`
	`144`	`+ endLine: 1,`
	`145`	`+ endColumn: 31`
`125`	`146`	`}`
`126`	`147`	`]`
`127`	`148`	`},`
`@@ -137,17 +158,23 @@ ruleTester.run('html-button-has-type', rule, {`
`137`	`158`	`{`
`138`	`159`	`message: 'button is a forbidden value for button type attribute.',`
`139`	`160`	`line: 2,`
`140`		`- column: 30`
	`161`	`+ column: 30,`
	`162`	`+ endLine: 2,`
	`163`	`+ endColumn: 38`
`141`	`164`	`},`
`142`	`165`	`{`
`143`	`166`	`message: 'submit is a forbidden value for button type attribute.',`
`144`	`167`	`line: 3,`
`145`		`- column: 30`
	`168`	`+ column: 30,`
	`169`	`+ endLine: 3,`
	`170`	`+ endColumn: 38`
`146`	`171`	`},`
`147`	`172`	`{`
`148`	`173`	`message: 'reset is a forbidden value for button type attribute.',`
`149`	`174`	`line: 4,`
`150`		`- column: 30`
	`175`	`+ column: 30,`
	`176`	`+ endLine: 4,`
	`177`	`+ endColumn: 37`
`151`	`178`	`}`
`152`	`179`	`]`
`153`	`180`	`},`
`@@ -165,17 +192,23 @@ ruleTester.run('html-button-has-type', rule, {`
`165`	`192`	`{`
`166`	`193`	`message: 'reset is a forbidden value for button type attribute.',`
`167`	`194`	`line: 4,`
`168`		`- column: 30`
	`195`	`+ column: 30,`
	`196`	`+ endLine: 4,`
	`197`	`+ endColumn: 37`
`169`	`198`	`},`
`170`	`199`	`{`
`171`	`200`	`message: 'A value must be set for button type attribute.',`
`172`	`201`	`line: 5,`
`173`		`- column: 30`
	`202`	`+ column: 30,`
	`203`	`+ endLine: 5,`
	`204`	`+ endColumn: 32`
`174`	`205`	`},`
`175`	`206`	`{`
`176`	`207`	`message: 'foo is an invalid value for button type attribute.',`
`177`	`208`	`line: 6,`
`178`		`- column: 30`
	`209`	`+ column: 30,`
	`210`	`+ endLine: 6,`
	`211`	`+ endColumn: 35`
`179`	`212`	`}`
`180`	`213`	`]`
`181`	`214`	`},`
`@@ -185,11 +218,17 @@ ruleTester.run('html-button-has-type', rule, {`
`185`	`218`	`errors: [`
`186`	`219`	`{`
`187`	`220`	`message: 'Missing an explicit type attribute for button.',`
`188`		`- column: 11`
	`221`	`+ column: 11,`
	`222`	`+ line: 1,`
	`223`	`+ endLine: 1,`
	`224`	`+ endColumn: 19`
`189`	`225`	`},`
`190`	`226`	`{`
`191`	`227`	`message: 'Missing an explicit type attribute for button.',`
`192`		`- column: 39`
	`228`	`+ column: 39,`
	`229`	`+ line: 1,`
	`230`	`+ endLine: 1,`
	`231`	`+ endColumn: 47`
`193`	`232`	`}`
`194`	`233`	`]`
`195`	`234`	`},`
`@@ -199,7 +238,10 @@ ruleTester.run('html-button-has-type', rule, {`
`199`	`238`	`errors: [`
`200`	`239`	`{`
`201`	`240`	`message: 'A value must be set for button type attribute.',`
`202`		`- column: 25`
	`241`	`+ column: 25,`
	`242`	`+ line: 1,`
	`243`	`+ endLine: 1,`
	`244`	`+ endColumn: 27`
`203`	`245`	`}`
`204`	`246`	`]`
`205`	`247`	`}`