Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/compiler-builtins
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master@{1day}
Choose a base ref
...
head repository: rust-lang/compiler-builtins
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 7, 2025

  1. symcheck: Store the section name in SymInfo if available 

    Currently `SymInfo` stores a `Section`, which is just an index:

    SymInfo {
        section: Section(
            SectionIndex(
                539,
            ),
        ),
        ...
    },

Look up and store the section name instead if possible, with a fallback
to the `Section` debug printing. This makes output more clear and will
allow us to filter by section name.
    @tgross35
    tgross35 committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    9caec5d View commit details
    Browse the repository at this point in the history

  2. symcheck: Ignore symbols in .debug_gdb_scripts 

    Since [1], our object files may now contain a GDB script section. These
symbols wind up with multiple instances in the archive but are weak, so
we can safely ignore them in our duplicates check.

This resolves the current CI failures.

[1]: rust-lang/rust#143679
    @tgross35
    tgross35 committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    e74519e View commit details
    Browse the repository at this point in the history

  3. Remove instances of allow(improper_ctypes) 

    i128/u128 haven't flagged `improper_ctypes` for a while, and this just
made it to stable [1]. Remove the `allow`s as they are no longer needed.

[1]: https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#i128-and-u128-in-extern-c-functions
    @tgross35
    tgross35 committed Aug 7, 2025
    Configuration menu
    Copy the full SHA
    6c8bf5a View commit details
    Browse the repository at this point in the history
Loading