Skip to content

Add Either support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"eslint": "eslint .",
"eslint:fix": "eslint . --fix",
"prepublishOnly": "npm run clean && npm run release",
"codecov": "codecov --token=66c30c23-8954-4892-bef9-fbaed0a2e42b"
"codecov": "codecov"
},
"dependencies": {
"camelcase": "^6.3.0",
Expand Down
1 change: 1 addition & 0 deletions src/client/interfaces/Operation.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ export interface Operation extends OperationParameters {
path: string;
errors: OperationError[];
results: OperationResponse[];
errorResults: OperationResponse[];
responseHeader: string | null;
}
9 changes: 8 additions & 1 deletion src/openApi/v2/parser/getOperation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { getOperationName } from './getOperationName';
import { getOperationParameters } from './getOperationParameters';
import { getOperationResponseHeader } from './getOperationResponseHeader';
import { getOperationResponses } from './getOperationResponses';
import { getOperationResults } from './getOperationResults';
import { getOperationErrorResults, getOperationResults } from './getOperationResults';
import { getServiceName } from './getServiceName';
import { sortByRequired } from './sortByRequired';

Expand Down Expand Up @@ -41,6 +41,7 @@ export const getOperation = (
imports: [],
errors: [],
results: [],
errorResults: [],
responseHeader: null,
};

Expand All @@ -61,13 +62,19 @@ export const getOperation = (
if (op.responses) {
const operationResponses = getOperationResponses(openApi, op.responses);
const operationResults = getOperationResults(operationResponses);
const operationErrorResults = getOperationErrorResults(operationResponses);
operation.errors = getOperationErrors(operationResponses);
operation.responseHeader = getOperationResponseHeader(operationResults);

operationResults.forEach(operationResult => {
operation.results.push(operationResult);
operation.imports.push(...operationResult.imports);
});

operationErrorResults.forEach(operationResult => {
operation.errorResults.push(operationResult);
operation.imports.push(...operationResult.imports);
});
}

operation.parameters = operation.parameters.sort(sortByRequired);
Expand Down
35 changes: 35 additions & 0 deletions src/openApi/v2/parser/getOperationResults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@ const areEqual = (a: Model, b: Model): boolean => {
return equal;
};

export const getOperationErrorResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
const operationResults: OperationResponse[] = [];

operationResponses.forEach(operationResponse => {
const { code } = operationResponse;
if (code && (code === 204 || code < 200 || code >= 300)) {
operationResults.push(operationResponse);
}
});

if (!operationResults.length) {
operationResults.push({
in: 'response',
name: '',
code: 0,
description: '',
export: 'generic',
type: 'any',
base: 'any',
template: null,
link: null,
isDefinition: false,
isReadOnly: false,
isRequired: false,
isNullable: false,
imports: [],
enum: [],
enums: [],
properties: [],
});
}

return operationResults;
};

export const getOperationResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
const operationResults: OperationResponse[] = [];

Expand Down
9 changes: 8 additions & 1 deletion src/openApi/v3/parser/getOperation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getOperationParameters } from './getOperationParameters';
import { getOperationRequestBody } from './getOperationRequestBody';
import { getOperationResponseHeader } from './getOperationResponseHeader';
import { getOperationResponses } from './getOperationResponses';
import { getOperationResults } from './getOperationResults';
import { getOperationErrorResults, getOperationResults } from './getOperationResults';
import { getRef } from './getRef';
import { getServiceName } from './getServiceName';
import { sortByRequired } from './sortByRequired';
Expand Down Expand Up @@ -44,6 +44,7 @@ export const getOperation = (
imports: [],
errors: [],
results: [],
errorResults: [],
responseHeader: null,
};

Expand Down Expand Up @@ -72,13 +73,19 @@ export const getOperation = (
if (op.responses) {
const operationResponses = getOperationResponses(openApi, op.responses);
const operationResults = getOperationResults(operationResponses);
const operationErrorResults = getOperationErrorResults(operationResponses);
operation.errors = getOperationErrors(operationResponses);
operation.responseHeader = getOperationResponseHeader(operationResults);

operationResults.forEach(operationResult => {
operation.results.push(operationResult);
operation.imports.push(...operationResult.imports);
});

operationErrorResults.forEach(operationResult => {
operation.errorResults.push(operationResult);
operation.imports.push(...operationResult.imports);
});
}

operation.parameters = operation.parameters.sort(sortByRequired);
Expand Down
35 changes: 35 additions & 0 deletions src/openApi/v3/parser/getOperationResults.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,41 @@ const areEqual = (a: Model, b: Model): boolean => {
return equal;
};

export const getOperationErrorResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
const operationResults: OperationResponse[] = [];

operationResponses.forEach(operationResponse => {
const { code } = operationResponse;
if (code && (code === 204 || code < 200 || code >= 300)) {
operationResults.push(operationResponse);
}
});

if (!operationResults.length) {
operationResults.push({
in: 'response',
name: '',
code: 0,
description: '',
export: 'generic',
type: 'any',
base: 'any',
template: null,
link: null,
isDefinition: false,
isReadOnly: false,
isRequired: false,
isNullable: false,
imports: [],
enum: [],
enums: [],
properties: [],
});
}

return operationResults;
};

export const getOperationResults = (operationResponses: OperationResponse[]): OperationResponse[] => {
const operationResults: OperationResponse[] = [];

Expand Down
11 changes: 7 additions & 4 deletions src/templates/core/ApiError.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,17 @@
import type { ApiRequestOptions } from './ApiRequestOptions';
import type { ApiResult } from './ApiResult';

export class ApiError extends Error {
export class ApiError<
StatusCode extends number = number,
ApiErrorBody = any,
> extends Error {
public readonly url: string;
public readonly status: number;
public readonly status: StatusCode;
public readonly statusText: string;
public readonly body: any;
public readonly body: ApiErrorBody;
public readonly request: ApiRequestOptions;

constructor(request: ApiRequestOptions, response: ApiResult, message: string) {
constructor(request: ApiRequestOptions, response: ApiResult<StatusCode, ApiErrorBody>, message: string) {
super(message);

this.name = 'ApiError';
Expand Down
21 changes: 18 additions & 3 deletions src/templates/core/ApiResult.hbs
Original file line number Diff line number Diff line change
@@ -1,9 +1,24 @@
{{>header}}

export type ApiResult = {
export type ApiResult<
StatusCode extends number = number,
ApiErrorBody = any,
> = {
readonly url: string;
readonly ok: boolean;
readonly status: number;
readonly status: StatusCode;
readonly statusText: string;
readonly body: any;
readonly body: ApiErrorBody;
};

export interface Left<E> {
readonly _tag: 'Left';
readonly left: E;
}

export interface Right<A> {
readonly _tag: 'Right';
readonly right: A;
}

export type Either<E, A> = Left<E> | Right<A>;
127 changes: 127 additions & 0 deletions src/templates/exportService.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,14 @@ import type { CancelablePromise } from '../core/CancelablePromise';
import { BaseHttpRequest } from '../core/BaseHttpRequest';
{{else}}
import type { BaseHttpRequest } from '../core/BaseHttpRequest';
import type { Left, Right, Either } from '../core/ApiResult';
import type { ApiError } from '../core/ApiError';
{{/equals}}
{{else}}
import { OpenAPI } from '../core/OpenAPI';
import { request as __request } from '../core/request';
import type { Left, Right, Either } from '../core/ApiResult';
import type { ApiError } from '../core/ApiError';
{{/if}}

{{#equals @root.httpClient 'angular'}}
Expand Down Expand Up @@ -146,5 +150,128 @@ export class {{{name}}}{{{@root.postfix}}} {
});
}

{{#equals @root.httpClient 'angular'}}
{{else}}
/**
{{#if deprecated}}
* @deprecated
{{/if}}
{{#if summary}}
* {{{escapeComment summary}}}
{{/if}}
{{#if description}}
* {{{escapeComment description}}}
{{/if}}
{{#unless @root.useOptions}}
{{#if parameters}}
{{#each parameters}}
* @param {{{name}}} {{#if description}}{{{escapeComment description}}}{{/if}}
{{/each}}
{{/if}}
{{/unless}}
{{#each results}}
* @returns {{{type}}} {{#if description}}{{{escapeComment description}}}{{/if}}
{{/each}}
* @throws ApiError
*/
{{#if @root.exportClient}}
{{#equals @root.httpClient 'angular'}}
public async {{{name}}}Either({{>parameters}}): Observable<{{>result}}> {
try {
const result: ({{>result}}) = await this.httpRequest.request({
{{else}}
public async {{{name}}}Either({{>parameters}}): Promise<Either<{{>errorResult}}, {{>result}}>> {
try {
const result: ({{>result}}) = await this.httpRequest.request({
{{/equals}}
{{else}}
{{#equals @root.httpClient 'angular'}}
public async {{{name}}}Either({{>parameters}}): Observable<{{>result}}> {
try {
const result: ({{>result}}) = await __request(OpenAPI, this.http, {
{{else}}
public static async {{{name}}}Either({{>parameters}}): Promise<Either<{{>errorResult}}, {{>result}}>> {
try {
const result: ({{>result}}) = await __request(OpenAPI, {
{{/equals}}
{{/if}}
method: '{{{method}}}',
url: '{{{path}}}',
{{#if parametersPath}}
path: {
{{#each parametersPath}}
'{{{prop}}}': {{{name}}},
{{/each}}
},
{{/if}}
{{#if parametersCookie}}
cookies: {
{{#each parametersCookie}}
'{{{prop}}}': {{{name}}},
{{/each}}
},
{{/if}}
{{#if parametersHeader}}
headers: {
{{#each parametersHeader}}
'{{{prop}}}': {{{name}}},
{{/each}}
},
{{/if}}
{{#if parametersQuery}}
query: {
{{#each parametersQuery}}
'{{{prop}}}': {{{name}}},
{{/each}}
},
{{/if}}
{{#if parametersForm}}
formData: {
{{#each parametersForm}}
'{{{prop}}}': {{{name}}},
{{/each}}
},
{{/if}}
{{#if parametersBody}}
{{#equals parametersBody.in 'formData'}}
formData: {{{parametersBody.name}}},
{{/equals}}
{{#equals parametersBody.in 'body'}}
body: {{{parametersBody.name}}},
{{/equals}}
{{#if parametersBody.mediaType}}
mediaType: '{{{parametersBody.mediaType}}}',
{{/if}}
{{/if}}
{{#if responseHeader}}
responseHeader: '{{{responseHeader}}}',
{{/if}}
{{#if errors}}
errors: {
{{#each errors}}
{{{code}}}: `{{{escapeDescription description}}}`,
{{/each}}
},
{{/if}}
});

const right: Right<{{>result}}> = {
_tag: 'Right',
right: result,
};

return right;
} catch (e) {
const left: Left<{{>errorResult}}> = {
_tag: 'Left',
left: e as ({{>errorResult}}),
};

return left;
}
}
{{/equals}}


{{/each}}
}
5 changes: 5 additions & 0 deletions src/templates/partials/errorResult.hbs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{{~#if errorResults~}}
{{#each errorResults}}ApiError<{{#equals code 0}}number{{else}}{{{code}}}{{/equals}}, {{type}}>{{#unless @last}} | {{/unless}}{{/each}}
{{~else~}}
ApiError<number, any>
{{~/if~}}
2 changes: 2 additions & 0 deletions src/utils/registerHandlebarTemplates.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ import templateExportSchema from '../templates/exportSchema.hbs';
import templateExportService from '../templates/exportService.hbs';
import templateIndex from '../templates/index.hbs';
import partialBase from '../templates/partials/base.hbs';
import partialErrorResult from '../templates/partials/errorResult.hbs';
import partialExportComposition from '../templates/partials/exportComposition.hbs';
import partialExportEnum from '../templates/partials/exportEnum.hbs';
import partialExportInterface from '../templates/partials/exportInterface.hbs';
Expand Down Expand Up @@ -148,6 +149,7 @@ export const registerHandlebarTemplates = (root: {
Handlebars.registerPartial('isRequired', Handlebars.template(partialIsRequired));
Handlebars.registerPartial('parameters', Handlebars.template(partialParameters));
Handlebars.registerPartial('result', Handlebars.template(partialResult));
Handlebars.registerPartial('errorResult', Handlebars.template(partialErrorResult));
Handlebars.registerPartial('schema', Handlebars.template(partialSchema));
Handlebars.registerPartial('schemaArray', Handlebars.template(partialSchemaArray));
Handlebars.registerPartial('schemaDictionary', Handlebars.template(partialSchemaDictionary));
Expand Down
Loading