Vipergts450 custom ___location patch #1081
Merged
+54
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ability for custom ___location templates to handle includes
Amend renderLocations to pass more host parameters into the custom locations to match the requirements set for the default ___location. This will apply all parameters set in the UI to all custom locations.
Allow more of the main host parameters into the custom ___location configuration and reorder to make more sense.
|
This is an automated message from CI: Docker Image for build 3 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
jc21
added
the
requires-verification
|
Have been running this patch at home on my network in production since I submitted this (I like to live dangerously) and it has been working great so far. |
|
This is an automated message from CI: Docker Image for build 6 is available on DockerHub as Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly resolves jc21#148 jc21#590 but needs a lot of testing as I roughed this together. Probably can replace the top block with a modified
include conf.d/include/proxy.conf;Allows custom locations to follow the rules set on the primary page such as Websockets, forcing SSL, HSTS, etc.
Made a couple of amendments to
/backend/templates/_location.confand/backend/internal/nginx.jsto allow the custom ___location templates to have includes which should flesh out their configs and follow the settings of the main configuration page. Needs a lot of testing.