Skip to content

Fixes custom certificate upload modal #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Conversation

chaptergy
Copy link
Collaborator

Fixes #1676

@jc21
Copy link
Member

jc21 commented Dec 23, 2021

This is an automated message from CI:

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-1677

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@SolarisEclipse
Copy link

Modal is still broken.

I can see that this commit is having issues, but it doesn't seem to have fixed the modal. I pulled and launched GitHub-pr-1677, but the modal is still broken.

ezgif-3-fe0b2f44ff

Screen Shot 2021-12-23 at 9 12 31 AM

@chaptergy
Copy link
Collaborator Author

@SolarisEclipse Have you cleared your browser cache so you are sure you are not seeing the cached old version of the website?

@SolarisEclipse
Copy link

Verifying, I hope I wasn't stupid enough to forget that. haha

@SolarisEclipse
Copy link

Nope, still broken. I didn't think I'd forget something like that. here's a gif.
ezgif-5-7b3cb77fdc

@hyun007
Copy link

hyun007 commented Dec 23, 2021

the fix works for me

@SolarisEclipse

This comment has been minimized.

@krautech
Copy link

Fix doesnt work for me

@jonyhartron
Copy link

Fix worked for me. thanks @chaptergy

@DrProphet0
Copy link

After updating and clearing the cache it fixed the issue.
Thank you!

@chaptergy
Copy link
Collaborator Author

chaptergy commented Dec 24, 2021

For anyone where this fix doesn't seem to work, make sure you are using docker image jc21/nginx-proxy-manager:github-pr-1677 and NOT :latest or :2.9.13 and you have cleared the browser cache. If the issue still persists, I'll need to know the logs of your browsers developer console to know what the issue might be

@mikedelgaudio
Copy link

This fix worked for me!

@hoochster
Copy link

This did work for me as well. Thank you so much. So when time comes to upgrade, just changing back to latest should work fine?

@jc21 jc21 merged commit 40b1521 into develop Dec 27, 2021
@chaptergy
Copy link
Collaborator Author

@hoochster Yes, once 2.9.14 is released, you can just swich your tag back to that

@wrightmt
Copy link

wrightmt commented Jan 4, 2022

Great this worked, thanks!

@arnolddwarf
Copy link

Thanks, it worked for me.

@jc21 jc21 deleted the fixes-custom-certificate-modal branch March 24, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button not working for Add Certificate --> Custom