Skip to content

Allow including custom nginx conf files #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Allow including custom nginx conf files #178

merged 3 commits into from
Aug 9, 2019

Conversation

cmer
Copy link
Contributor

@cmer cmer commented Jul 26, 2019

Give advanced users more flexibility by allowing them to include custom config files at differents locations in the nginx configuration.

/data/nginx/custom/root.conf: Included at the very end of nginx.conf
/data/nginx/custom/http.conf: Included at the end of the main http block
/data/nginx/custom/server_proxy.conf: Included at the end of every proxy server block
/data/nginx/custom/server_redirect.conf: Included at the end of every redirection server block
/data/nginx/custom/server_stream.conf: Included at the end of every stream server block
/data/nginx/custom/server_stream_tcp.conf: Included at the end of every TCP stream server block
/data/nginx/custom/server_stream_udp.conf: Included at the end of every UDP stream server block

Give advanced users more flexibility by allowing them to include custom config files at differents locations in the nginx configuration.

`/data/nginx/custom/root.conf`: Included at the very end of nginx.conf
`/data/nginx/custom/http.conf`: Included at the end of the main `http` block
`/data/nginx/custom/server_proxy.conf`: Included at the end of every proxy `server` block
`/data/nginx/custom/server_redirect.conf`: Included at the end of every redirection `server` block
`/data/nginx/custom/server_stream.conf`: Included at the end of every stream `server` block
`/data/nginx/custom/server_stream_tcp.conf`: Included at the end of every TCP stream `server` block
`/data/nginx/custom/server_stream_udp.conf`: Included at the end of every UDP stream `server` block
@jc21
Copy link
Member

jc21 commented Jul 26, 2019

Docker Image for build 1 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-178-amd64

@jc21
Copy link
Member

jc21 commented Aug 9, 2019

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-178-amd64

@cmer
Copy link
Contributor Author

cmer commented Aug 9, 2019

Is there any interest in this @jc21? Seems like a sensible thing to add for power users? TIA!

@jc21
Copy link
Member

jc21 commented Aug 9, 2019

Yeah it wouldn't hurt. Might need some documentation, could you make a new markdown file in doc folder?

@cmer
Copy link
Contributor Author

cmer commented Aug 9, 2019

I added some docs. LMK if this is what you had in mind or not.

@jc21
Copy link
Member

jc21 commented Aug 9, 2019

Awesome. Pull the CI docker image here and give it a real world test. If you're happy with it I'll merge.

@jc21
Copy link
Member

jc21 commented Aug 9, 2019

Docker Image for build 3 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-178-amd64

@cmer
Copy link
Contributor Author

cmer commented Aug 9, 2019

Works for me... and doesn't cause issues if custom snippet files are not present.

@jc21 jc21 merged commit 31aa9c9 into NginxProxyManager:master Aug 9, 2019
@jc21
Copy link
Member

jc21 commented Aug 9, 2019

If you want to do more patches in future, can you please push them to the develop branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants