📚 add arabic local for V3 #2104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jc21
reviewed
Aug 23, 2022
| "access-lists.title": { | ||
| "defaultMessage": "قوائم الوصول" | ||
| }, | ||
| "acmesh.dns_acmedns": { |
There was a problem hiding this comment.
It's worth noting that if a definition doesn't exist here it will fall back to the en.json value. For lang keys starting with acmesh. you don't need to add them here since they should have the same value in each language. However if they are different then sure, add them. I mention it because it will decrease the size of the frontend package if we don't need to repeat this list, and this list of supported DNS providers is definitely going to grow.
|
Looks good and thanks for contributing here. Just that one comment from me. Since this is an unreleased-dev branch it's not greatly documented, however you can ensure that the language files are happy by running the following: cd frontend
yarn install
yarn check-localesThe CI will run this and fail the PR if this script isn't happy. |
|
|
CI Error: |
jc21
force-pushed
the
v3
branch
3 times, most recently
from
6b05095 to
d94e304
Compare
|
PR is now considered stale. If you want to keep it open, please comment 👍 |
jc21
force-pushed
the
v3
branch
16 times, most recently
from
0f0230f to
efd47a0
Compare
jc21
force-pushed
the
v3
branch
2 times, most recently
from
8213b3a to
2080379
Compare
|
PR is now considered stale. If you want to keep it open, please comment 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there !
thanks for all work, I hope you accept this RP