Added default HTTPs site. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to adjust the change, as it seems to break proxy hosts with SSL... |
jlesage
force-pushed
the
default-https-site
branch
2 times, most recently
from
f9854f4 to
20fd185
Compare
|
Ok I adjusted the default site and now it's working fine. |
|
Great stuff :) I'll add a bit of debug output for the dummy cert generation prior to the next release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a default site for HTTPs, another configured host will be wrongly used.
For example, when trying to access, via HTTP, a host that has not been setup yet, we get the "Congratulations" page as expected. However, doing the same via HTTPs does't show this default page, but shows a configured proxy host (for which SSL is enabled).
The same issue happen when configuring a host without enabling SSL: Access the host over HTTP works fine, but accessing the same host via HTTPs will show the page associated to another configured host.
Since there is no certificate associated to the default site, its configuration only return the special code
444, which makes nginx to close the connection.