Changes log filenames from ID to (first) ___domain

[joewesch]

Closes: #746

This change would be slightly not backwards compatible as the log filenames would change for all new logs and all existing files would be abandoned and not pruned. Any guidance or assistance to add this as a setting in the UI or something rather than just change the default would be welcomed.

[KGBist2000]

Hi Joewesch,
nice change. Did you checked what will happen, if more then one ___domain is entered into the gui by creating a new host ?

[joewesch]

Hello @KGBist2000.

Yes, it uses the alphabetically first ___domain in the filename. For example, if you create a proxy host with the 2 domains beta.example.com and alpha.example.com the log files would be proxy-host-alpha.example.com_access.log and proxy-host-alpha.example.com_error.log.

I have been using this method for quite some time with no problems starting shortly after I opened the linked issue. I only just recently was reminded I never put in a PR via a recent comment on the issue.

[csantospminds]

I'm very interested in this, any idea if it's possible to change the log filename from ID to ___domain?
Adding the option to read the logs in the GUI would also be cool because right now it's difficult to find a particular log for a dozen or more vhosts.

[hirenshah]

Could this be expanded to name the conf files in a similar manner?

[pXius]

Is this PR still being considered?

[joewesch]

Pinging @jc21 to see if there is any feedback?

[nginxproxymanagerci]

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from nginxproxymanager/nginx-full
Digest: sha256:eaa2ebcb50dd87557c9a8f95a3230128d94cac1ea17800261c036e59378e7d49
Status: Image is up to date for nginxproxymanager/nginx-full:certbot-node
docker.io/nginxproxymanager/nginx-full:certbot-node
�[1;34m❯ �[1;36mBuilding Frontend ...�[0m
yarn install v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads https://github.com/tabler/tabler.git
Directory: /app/frontend
Output:
fatal: unable to access 'https://github.com/tabler/tabler.git/': Failed to connect to github.com port 443 after 10012 ms: Couldn't connect to server

[github-actions]

PR is now considered stale. If you want to keep it open, please comment 👍