Skip to content

allow ___domain like 'com.example.com:8080' #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

allow ___domain like 'com.example.com:8080' #2611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f00fe27
allow ___domain like 'com.example.com:8080',use external port and nginx …
constanine Feb 13, 2023
fb1e4bd
Update proxy_host.conf by replace $host:$server with $http_host
constanine Jul 31, 2023
75c2f73
Merge branch 'NginxProxyManager:develop' into issue_for_external_port
constanine Jul 31, 2023
4ebfb42
bugfix when create a proxy-host.conf can with more ports
Jul 31, 2023
dec0ff3
bugfix when create a proxy-host.conf can with more ports
Jul 31, 2023
05831fc
formatting nginx.js
Jul 31, 2023
c166f6b
formatting nginx.js
Jul 31, 2023
bbeb4f5
formatting nginx.js
Jul 31, 2023
7f2552d
formatting nginx.js
Jul 31, 2023
700d908
varible listen_ports should be in case which nice_host_type is proxy_…
Jul 31, 2023
5dbb0b9
Strings must use singlequote quotes
Jul 31, 2023
145fe2d
Strings must use singlequote quotes
Jul 31, 2023
1a98365
proxy_set_header Host is not useful in proxy_host.conf,it should be m…
Aug 11, 2023
4cb39fe
is more suitable for ,if listen port is no 80 or 443
Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions backend/internal/nginx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,19 @@ const internalNginx = {

// Set the IPv6 setting for the host
host.ipv6 = internalNginx.ipv6Enabled();


if ( nice_host_type === 'proxy_host' ) {
let listen_ports = [];
host.domain_names.map( function (domain_name) {
if ( domain_name.indexOf(':') > 0 ){
listen_ports.push(parseInt(domain_name.substring(domain_name.indexOf(':')+1)));
}
});
if ( listen_ports.length > 0 ){
host.listen_ports = listen_ports;
}
}

locationsPromise.then(() => {
renderEngine
Expand Down
3 changes: 3 additions & 0 deletions backend/templates/_listen.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@
#listen [::]:443;
{% endif %}
{% endif %}
{% for listen_port in listen_ports %}
listen listen_port;
{% endfor %}
server_name {{ domain_names | join: " " }};
2 changes: 1 addition & 1 deletion docker/rootfs/etc/nginx/conf.d/include/proxy.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
add_header X-Served-By $host;
proxy_set_header Host $host;
proxy_set_header Host $http_host;
proxy_set_header X-Forwarded-Scheme $scheme;
proxy_set_header X-Forwarded-Proto $scheme;
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
Expand Down