Skip to content

Fix for testing SSL certificates (Possibly Issue #2011) #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix for testing SSL certificates (Possibly Issue #2011) #2851

wants to merge 3 commits into from

Conversation

S-T-3-V-3
Copy link

  • Keepalive, User Agent + Accept headers
  • Catch added for failed JSON parsing
  • More accurate errors displayed to user

@S-T-3-V-3
Fix for SSL certificate error NginxProxyManager#2011
cc54656 
- Keepalive, User Agent + Accept headers
- Catch added for failed JSON parsing
- More accurate errors displayed to user
@S-T-3-V-3
Copy link
Author

This looks like Jenkins encountered an unrelated issue

jc21
jc21 reviewed Jul 30, 2023
View reviewed changes
backend/internal/certificate.js Outdated
const parsedBody = JSON.parse(responseBody + '');
resolve(parsedBody);
}
catch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be

} catch (err) {
    logger.warn("Error: " + err.message);

@nginxproxymanagerci
Copy link

CI Error:

/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
certbot-node: Pulling from jc21/nginx-full
Digest: sha256:80d606222dc80504bb6b07decc040b6ff4fd3eb30d0cd9ed8e83babe02fd3773
Status: Image is up to date for jc21/nginx-full:certbot-node
docker.io/jc21/nginx-full:certbot-node
yarn install v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
Done in 7.11s.
yarn run v1.22.19
$ /app/node_modules/.bin/eslint .

/app/internal/certificate.js
  1167:22  error  Extra space before value for key 'Content-Length'  key-spacing
  1168:22  error  Missing space before value for key 'Connection'    key-spacing
  1169:22  error  Missing space before value for key 'User-Agent'    key-spacing
  1170:18  error  Missing space before value for key 'Accept'        key-spacing

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@S-T-3-V-3
Copy link
Author

Seems like some pretty inconsistent linting 🤔

@jlesage
Copy link
Contributor

jlesage commented Jan 8, 2024

Note that successfully parsing the body as JSON doesn't mean that the test was successful. See #3388

@github-actions GitHub Actions
Copy link

PR is now considered stale. If you want to keep it open, please comment 👍

@github-actions github-actions bot added the stale label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jc21 jc21 jc21 left review comments

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@S-T-3-V-3 @jlesage @jc21