Skip to content

Allow DNS challenges not just for cloudflare #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 14, 2020

Conversation

chaptergy
Copy link
Collaborator

@chaptergy chaptergy commented Oct 6, 2020

This merge request would allow way more providers for DNS challenges to request wildcard certificates, not just for Cloudflare users.
These new providers are collected in an easily maintainable list global/certbot-dns-plugins.js.

As a little bonus "Internal Errors" as thrown by the backend now show the stack of what exactly went wrong, so users can sort out some problems on their own. This was requested in issue #627 as well.

@chaptergy chaptergy changed the title Allow DNS challenges not just for cloudflare WIP: Allow DNS challenges not just for cloudflare Oct 6, 2020
@chaptergy chaptergy marked this pull request as draft October 7, 2020 14:24
@chaptergy chaptergy force-pushed the allow-more-dns-challenges branch from e4a47ee to 3fec135 Compare October 8, 2020 12:38
@jc21
Copy link
Member

jc21 commented Oct 8, 2020

Docker Image for build 6 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-635

@jc21
Copy link
Member

jc21 commented Oct 8, 2020

Docker Image for build 7 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-635

@chaptergy chaptergy changed the title WIP: Allow DNS challenges not just for cloudflare Allow DNS challenges not just for cloudflare Oct 8, 2020
@chaptergy chaptergy marked this pull request as ready for review October 8, 2020 14:44
@jc21 jc21 changed the base branch from master to develop October 13, 2020 00:44
@jc21
Copy link
Member

jc21 commented Oct 13, 2020

Amazing work! I'm unable to test 100% because I use AWS Route53 for my DNS and it's not in the list. Can you confirm which providers you have successfully tested with?

@jc21
Copy link
Member

jc21 commented Oct 13, 2020

Docker Image for build 8 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-635

@chaptergy
Copy link
Collaborator Author

Route 53 is at the very bottom of the list but should be there.
Unfortunately I myself was only able to test Njalla, and get a friend of mine to test DNSimple, however I figured no one would be able to test all of them, and if issues were present, they would arise over time. Issues would not be able to break any other working code and the list of providers would be easily maintainable. So removing a broken provider or changing it when the certbot plugin changes would require minimal effort and could be done by almost anyone.

@jc21
Copy link
Member

jc21 commented Oct 14, 2020

Ah yep I didn't look hard enough.

So I just tried this out and got this:

[10/14/2020] [5:30:02 AM] [Express  ] › ⚠  warning   Command failed: /usr/bin/certbot certonly --non-interactive --cert-name "npm-76" --agree-tos --email "[email protected]" --domains "dnstest.jc21.net.au" --authenticator dns-route53 --dns-route53-credentials "/etc/letsencrypt/credentials-76"
usage:
  certbot [SUBCOMMAND] [options] [-d DOMAIN] [-d DOMAIN] ...

Certbot can obtain and install HTTPS/TLS/SSL certificates.  By default,
it will attempt to use a webserver both for obtaining and installing the
certificate.
certbot: error: unrecognized arguments: --dns-route53-credentials /etc/letsencrypt/credentials-76

Looks like the arg isn't supported, and not sure if it's required since the AWS creds have to be supplied in other ways according to the certbot docs.

@chaptergy
Copy link
Collaborator Author

Oh yeah, AWS was the odd one out, I had a special case just for AWS in the frontend, however when it came to the backend I totally forgot about it. Unfortunately I can't test it myself, however I pushed some changes which I'm pretty sure should get Route53 working.

@jc21
Copy link
Member

jc21 commented Oct 14, 2020

Docker Image for build 10 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-635

@jc21
Copy link
Member

jc21 commented Oct 14, 2020

Route53 works now :)

@jc21 jc21 merged commit 3c4ce83 into NginxProxyManager:develop Oct 14, 2020
@aroundmyroom
Copy link

aroundmyroom commented Oct 14, 2020

how can I update for this?
I only do normally docker-compose up -d or docker-compose down

@jc21
Copy link
Member

jc21 commented Oct 14, 2020

Yep that will work once this is part of the main release. I usually create an official release a couple of days after going on a PR merge spree.

You can watch releases for this with the Watch button at that top of this page and when you get the email, do your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants