Skip to content

Feature/custom locations #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 4, 2019

Conversation

kolbii
Copy link
Contributor

@kolbii kolbii commented Feb 19, 2019

I've been using this tool for making requests between the projects and services, it's a great tool for that. But in that case, if a project has 2+ ___location path it gets difficult to use and understand.
Please take a look at this PR. I've added a new pane to Proxy host dialog as "Custom locations" where you'd be able to manaeg 2+ ___location blocks

screenshot1
screenshot2

@jc21
Copy link
Member

jc21 commented Feb 20, 2019

Ignore the CI errors for now, gotta get my CI pipelines working with PRs.

@jc21
Copy link
Member

jc21 commented Feb 20, 2019

Docker Image for build 5 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

@jc21
Copy link
Member

jc21 commented Feb 21, 2019

Docker Image for build 6 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

…into feature/custom-locations

# Conflicts:
#	src/backend/internal/nginx.js
#	src/backend/templates/proxy_host.conf
@jc21
Copy link
Member

jc21 commented Feb 25, 2019

Docker Image for build 7 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

@jc21
Copy link
Member

jc21 commented Feb 25, 2019

I've been a bit busy I'll try to review this properly this week

@jc21 jc21 mentioned this pull request Feb 27, 2019
@jc21
Copy link
Member

jc21 commented Mar 2, 2019

Docker Image for build 8 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

Copy link
Member

@jc21 jc21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks pretty good, just a few tweaks.

@jc21
Copy link
Member

jc21 commented Mar 4, 2019

Docker Image for build 9 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

@kolbii
Copy link
Contributor Author

kolbii commented Mar 4, 2019

Thanks for the feedback. You can find the fixes in the last commit

@jc21
Copy link
Member

jc21 commented Mar 4, 2019

Docker Image for build 10 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-74

@jc21 jc21 merged commit 71dfd5d into NginxProxyManager:develop Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants