-
Notifications
You must be signed in to change notification settings - Fork 9.1k
update XML namespace documentation #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc' @OAI/tdc |
so many whitespace changes makes this a tedious review... |
@@ -3023,12 +3023,12 @@ See examples for expected behavior. | |||
Field Name | Type | Description | |||
---|:---:|--- | |||
<a name="xmlName"></a>name | `string` | Replaces the name of the element/attribute used for the described schema property. When defined within `items`, it will affect the name of the individual XML elements within the list. When defined alongside `type` being `array` (outside the `items`), it will affect the wrapping element and only if `wrapped` is `true`. If `wrapped` is `false`, it will be ignored. | |||
<a name="xmlNamespace"></a>namespace | `string` | The URL of the namespace definition. Value SHOULD be in the form of a URL. | |||
<a name="xmlNamespace"></a>namespace | `string` | The URI of the namespace definition. Value MUST be in the form of an absolute URI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only content change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the only content changed. I didn't realize my editor (VS Code) did this. I fix this.
I didn't realize VS Code trimmed all of the empty whitespace after saving. There was only one line that changed that was not whitespace related. I can update the commit if need be. |
I don't think that's needed, I did call out the one change in your PR so others don't need to go mining. |
|
#TDC: @whitlockjc Would you please update whitespace so this does not cause conflict with other PRs |
|
The XML namespace documentation was changed to better reflect the expected value. We changed the value type from a URL to an absolute URI and the wording was that this is a strict requirement and not a suggestion. Fixes OAI#1084
94aca3e
to
b9d2ec7
Compare
Whitespace fixed. |
The XML namespace documentation was changed to better reflect the
expected value. We changed the value type from a URL to an absolute
URI and the wording was that this is a strict requirement and not a
suggestion.
Fixes #1084