Skip to content

update XML namespace documentation #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

whitlockjc
Copy link
Member

The XML namespace documentation was changed to better reflect the
expected value. We changed the value type from a URL to an absolute
URI and the wording was that this is a strict requirement and not a
suggestion.

Fixes #1084

@whitlockjc
Copy link
Member Author

cc' @OAI/tdc

@fehguy
Copy link
Contributor

fehguy commented May 11, 2017

so many whitespace changes makes this a tedious review...

@@ -3023,12 +3023,12 @@ See examples for expected behavior.
Field Name | Type | Description
---|:---:|---
<a name="xmlName"></a>name | `string` | Replaces the name of the element/attribute used for the described schema property. When defined within `items`, it will affect the name of the individual XML elements within the list. When defined alongside `type` being `array` (outside the `items`), it will affect the wrapping element and only if `wrapped` is `true`. If `wrapped` is `false`, it will be ignored.
<a name="xmlNamespace"></a>namespace | `string` | The URL of the namespace definition. Value SHOULD be in the form of a URL.
<a name="xmlNamespace"></a>namespace | `string` | The URI of the namespace definition. Value MUST be in the form of an absolute URI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only content change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only content changed. I didn't realize my editor (VS Code) did this. I fix this.

@whitlockjc
Copy link
Member Author

I didn't realize VS Code trimmed all of the empty whitespace after saving. There was only one line that changed that was not whitespace related. I can update the commit if need be.

@fehguy
Copy link
Contributor

fehguy commented May 11, 2017

I don't think that's needed, I did call out the one change in your PR so others don't need to go mining.

@webron
Copy link
Member

webron commented May 12, 2017

:shipit:

@RobDolinMS
Copy link
Contributor

#TDC: @whitlockjc Would you please update whitespace so this does not cause conflict with other PRs
#TDC: After that it's ready to merge with @fehguy @webron and @darrelmiller all giving thumbs-up.

@fehguy
Copy link
Contributor

fehguy commented Jun 1, 2017

:shipit:

The XML namespace documentation was changed to better reflect the
expected value.  We changed the value type from a URL to an absolute
URI and the wording was that this is a strict requirement and not a
suggestion.

Fixes OAI#1084
@whitlockjc whitlockjc force-pushed the xml-namespaces-changes branch from 94aca3e to b9d2ec7 Compare June 1, 2017 22:56
@whitlockjc
Copy link
Member Author

Whitespace fixed.

@webron webron merged commit 9036a04 into OAI:OpenAPI.next Jun 1, 2017
@webron webron mentioned this pull request Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants