Skip to content

Workflow to publish schemas #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions .github/workflows/schema-publish.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
name: schema-publish

# author: @ralfhandl
# issue: https://github.com/OAI/OpenAPI-Specification/issues/3715

#
# This workflow updates the respec 'pretty' rendered versions of the spec
# on the gh-pages branch when the corresponding markdown files change.
#

# run this on push to main
on:
push:
branches:
- main
workflow_dispatch: {}

jobs:
publish:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4 # checkout main branch
with:
fetch-depth: 0

- uses: actions/setup-node@v4 # setup Node.js
with:
node-version: '20.x'

- name: Install dependencies
run: npm ci

- uses: actions/checkout@v4 # checkout gh-pages branch
with:
ref: gh-pages
path: deploy

- name: run main script
run: scripts/schema-publish.sh

- name: Create Pull Request
uses: peter-evans/create-pull-request@v6
with:
token: ${{ secrets.GITHUB_TOKEN }}
branch: publish-schema-iteration
base: gh-pages
delete-branch: true
path: deploy
labels: Housekeeping,Schema
team-reviewers: OAI/tsc #TODO: check if this works, or if it needs a special access token
title: Publish OpenAPI Metaschema Iterations
commit-message: New OpenAPI metaschema iterations
signoff: true
body: |
This pull request is automatically triggered by GitHub action `schema-publish`.

The `schemas/**/*.yaml` files have changed and JSON files are automatically generated.


32 changes: 32 additions & 0 deletions scripts/schema-convert.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
#!/usr/bin/env node

'use strict';

const fs = require('fs');
const yaml = require('yaml');

function convert(filename,date) {
try {
const s = fs.readFileSync(filename,'utf8');
const obj = yaml.parse(s, {prettyErrors: true});
// replace last segment of id, $id, and $ref value with date
for (const p of ["id","$id","$ref"]) {
if (obj[p]) {
obj[p] = obj[p].replace(/\/[^\/]+$/,'/'+date);
}
}
console.log(JSON.stringify(obj,null,2));
}
catch (ex) {
console.warn(' ',ex.message);
process.exitCode = 1;
}
}

if (process.argv.length<4) {
console.warn('Usage: convert-schema.js file.yaml YYYY-MM-DD');
}
else {
convert(process.argv[2], process.argv[3]);
}

24 changes: 24 additions & 0 deletions scripts/schema-publish.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
#!/bin/bash

# Author: @ralfhandl

# run this script from the root of the repo. It is designed to be run by a GitHub workflow.

for filename in schemas/v3*/schema.yaml ; do
vVersion=$(basename $(dirname "$filename"))
version=${vVersion:1}
lastCommitDate=$(git log -1 --format="%ad" --date=short "$filename")

echo "$filename $lastCommitDate"
mkdir -p deploy/oas/$version/schema
node scripts/schema-convert.js "$filename" $lastCommitDate > deploy/oas/$version/schema/$lastCommitDate
mv deploy/oas/$version/schema/*.md deploy/oas/$version/schema/$lastCommitDate.md

filenameBase=$(dirname "$filename")/schema-base.yaml
if [ -f "$filenameBase" ]; then
echo "$filenameBase $lastCommitDate"
mkdir -p deploy/oas/$version/schema-base
node scripts/schema-convert.js "$filenameBase" $lastCommitDate > deploy/oas/$version/schema-base/$lastCommitDate
mv deploy/oas/$version/schema-base/*.md deploy/oas/$version/schema-base/$lastCommitDate.md
fi
done
3 changes: 1 addition & 2 deletions tests/md2html/md2html.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ import { readdirSync, readFileSync } from "node:fs";
import { exec } from "node:child_process";
import { resolve } from "node:path";
import { describe, test, expect } from "vitest";
import assert from "node:assert";

const folder = "./tests/md2html/fixtures/";
describe("v3.0 - Validate examples", async () => {
describe("Markdown to HTML", async () => {
readdirSync(folder, { withFileTypes: true })
.filter((entry) => entry.isFile() && /\.md$/.test(entry.name))
.forEach((entry) => {
Expand Down
8 changes: 8 additions & 0 deletions tests/schema-convert/fixtures/schema.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "https://spec.openapis.org/oas/3.0/schema/8765-43-21",
"$id": "https://spec.openapis.org/oas/3.0/schema/8765-43-21",
"$ref": "path/to/somewhere/8765-43-21",
"other": {
"foo": "bar"
}
}
5 changes: 5 additions & 0 deletions tests/schema-convert/fixtures/schema.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
id: https://spec.openapis.org/oas/3.0/schema/2024-10-17
$id: https://spec.openapis.org/oas/3.0/schema/some-iteration
$ref: path/to/somewhere/replace-last-segment
other:
foo: bar
58 changes: 58 additions & 0 deletions tests/schema-convert/schema-convert.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { readdirSync, readFileSync } from "node:fs";
import { exec } from "node:child_process";
import { resolve } from "node:path";
import { describe, test, expect } from "vitest";
import assert from "node:assert";

const folder = "./tests/schema-convert/fixtures/";
describe("Convert Schemas", async () => {
test("YAML with id, $id, $ref", async () => {
const expected = readFileSync(folder + "schema.json", "utf8");
const output = await convert(
[
"schema.yaml",
"8765-43-21",
],
folder,
);
expect(output.stdout).to.equal(expected);
});

test("non-existing input", async () => {
const output = await convert(
[
"does-not-exist",
"YYYYMMDD",
],
folder,
);
expect(output.stderr).to.equal(" ENOENT: no such file or directory, open 'does-not-exist'\n");
});

test("invalid parameters", async () => {
const output = await convert(
[
"schema.yaml",
],
folder,
);
expect(output.stderr).to.equal("Usage: convert-schema.js file.yaml YYYY-MM-DD\n");
});
});

function convert(args, cwd) {
return new Promise((res) => {
exec(
`node ${resolve("./scripts/schema-convert.js")} ${args.join(" ")}`,
{ cwd },
(error, stdout, stderr) => {
res({
code: error?.code || 0,
error,
stdout,
stderr,
});
},
);
});
}