Skip to content

Update this.context.environment.type to Environment.type to avoid issue from drop 6. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lee-borlace
Copy link
Contributor

No description provided.

@msftclas
Copy link

Hi @leeroy79, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@VesaJuvonen
Copy link
Contributor

thx Leeroy79, absolutely a valid fix and we will refresh the tutorials fully when the Release Candidate is released (really soon). We can though get this merged for now, if you re-target the submission to staging branch like explained in our contribution guidance - https://github.com/SharePoint/sp-dev-docs/blob/master/.github/CONTRIBUTING.md.

Thanks for the fix - absolutely valid change. Would also suggest to update your profile with your actual name details, so that we can give you credits on the contributions in our monthly communications, unless you want to stay anonymous. See December release notes as an example - https://dev.office.com/blogs/PnP-December-2016-Release.

@VesaJuvonen
Copy link
Contributor

thx Leeroy79, closing this one now that there's same push for the staging branch.

@lee-borlace
Copy link
Contributor Author

lee-borlace commented Dec 13, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants