Update to Resolving Dependancies - using npm ci #4142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using 'npm ci' instead of 'npm install' you can significantly improve the speed of the build process
New image to support change ot the documentation
In support of documentaiton update
|
|
|
Sorry for the delay... but can you update the PR to address the conflicts before we eval to merge? Thanks! |
andrewconnell
added
the
Needs: Author Feedback
|
Andrew,
I didn't know there were conflicts sorry :(
I also noticed yesterday(literally) that it is now out of date as well.
There is now a CI option on devops in addition to install and custom. So
it's even easier on the user.
So is it better to update my PR with the new instructions of reject it and
do another one?
Thanks,
Mark
…On Sat, Dec 7, 2019 at 8:47 AM Andrew Connell ***@***.***> wrote:
Sorry for the delay... but can you update the PR to address the conflicts
before we eval to merge? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4142?email_source=notifications&email_token=AAM5JVGLCF2ES5J2MWERC2TQXOZPNA5CNFSM4HX4N762YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGIJYI#issuecomment-562857185>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM5JVCF5IQ7PSP5HB2OUKTQXOZPNANCNFSM4HX4N76Q>
.
|
msft-github-bot
removed
the
Needs: Author Feedback
|
could have easily been a case where something changed AFTER you submitted so it's just the result of us not merging it in sooner. Either way... not a problem. It's up to you how you want to do it... there is another PR #4976 with a lot of changes to those docs if you want to wait until that's merged. As for the process, it doesn't matter if you close & resubmit, or if you just put another commit on top of it. |
baywet
approved these changes
Dec 7, 2019
andrewconnell
added
the
Needs: Author Feedback
andrewconnell
added
the
no-recent-activity
msft-github-bot
removed
the
no-recent-activity
andrewconnell
added
the
no-recent-activity
msft-github-bot
removed
the
no-recent-activity
|
bump... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation describes using npm install - using npm ci significantly improves the the speed of the build process. Seeing as this is the rate determining step for the overall build process doing everything we can to speed it up is important.
For reference
https://stackoverflow.com/a/53325242