Skip to content

Fix incorrect reversal in reverse_bits by removing redundant call #12869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions bit_manipulation/reverse_bits.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
def get_reverse_bit_string(number: int) -> str:
"""
return the bit string of an integer
Take in an 32 bit integer, reverse its bits,
return a string of reversed bits

>>> get_reverse_bit_string(9)
'10010000000000000000000000000000'
Expand All @@ -26,36 +27,36 @@ def get_reverse_bit_string(number: int) -> str:
return bit_string


def reverse_bit(number: int) -> str:
def get_reverse_bit_int(number: int) -> int:
"""
Take in an 32 bit integer, reverse its bits,
return a string of reverse bits
return a 32 bit integer of reversed bits

result of a reverse_bit and operation on the integer provided.
result of a get_reverse_bit and operation on the integer provided.

>>> reverse_bit(25)
'00000000000000000000000000011001'
>>> reverse_bit(37)
'00000000000000000000000000100101'
>>> reverse_bit(21)
'00000000000000000000000000010101'
>>> reverse_bit(58)
'00000000000000000000000000111010'
>>> reverse_bit(0)
'00000000000000000000000000000000'
>>> reverse_bit(256)
'00000000000000000000000100000000'
>>> reverse_bit(-1)
>>> get_reverse_bit_int(25)
2550136832
>>> get_reverse_bit_int(37)
2751463424
>>> get_reverse_bit_int(21)
2818572288
>>> get_reverse_bit_int(58)
1543503872
>>> get_reverse_bit_int(0)
0
>>> get_reverse_bit_int(256)
8388608
>>> get_reverse_bit_int(-1)
Traceback (most recent call last):
...
ValueError: the value of input must be positive

>>> reverse_bit(1.1)
>>> get_reverse_bit_int(1.1)
Traceback (most recent call last):
...
TypeError: Input value must be a 'int' type

>>> reverse_bit("0")
>>> get_reverse_bit_int("0")
Traceback (most recent call last):
...
TypeError: '<' not supported between instances of 'str' and 'int'
Expand All @@ -77,7 +78,7 @@ def reverse_bit(number: int) -> str:
number = number >> 1
# add that bit to our ans
result = result | end_bit
return get_reverse_bit_string(result)
return result


if __name__ == "__main__":
Expand Down