Skip to content

fix: add sleep for model deployment to fix flaky test #5260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix: add sleep for model deployment to fix flaky test #5260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/integ/test_multidatamodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import base64
import os
import time
import requests

import docker
Expand Down Expand Up @@ -138,6 +139,7 @@ def test_multi_data_model_deploy_pretrained_models(
multi_data_model.add_model(pretrained_model_data_local_path, PRETRAINED_MODEL_PATH_1)
# Deploy model to an endpoint
multi_data_model.deploy(1, cpu_instance_type, endpoint_name=endpoint_name)
time.sleep(30)
# Add models after deploy
multi_data_model.add_model(pretrained_model_data_local_path, PRETRAINED_MODEL_PATH_2)

Expand Down Expand Up @@ -266,6 +268,7 @@ def test_multi_data_model_deploy_trained_model_from_framework_estimator(
multi_data_model.add_model(mxnet_model_1.model_data, PRETRAINED_MODEL_PATH_1)
# Deploy model to an endpoint
multi_data_model.deploy(1, cpu_instance_type, endpoint_name=endpoint_name)
time.sleep(30)

# Train another model
mxnet_model_2 = _mxnet_training_job(
Expand Down Expand Up @@ -373,6 +376,7 @@ def test_multi_data_model_deploy_train_model_from_amazon_first_party_estimator(
multi_data_model.add_model(rcf_model_v1.model_data, PRETRAINED_MODEL_PATH_1)
# Deploy model to an endpoint
multi_data_model.deploy(1, cpu_instance_type, endpoint_name=endpoint_name)
time.sleep(30)
# Train another model
rcf_model_v2 = __rcf_training_job(
sagemaker_session, container_image, cpu_instance_type, 70, 20
Expand Down Expand Up @@ -470,6 +474,7 @@ def test_multi_data_model_deploy_pretrained_models_update_endpoint(
multi_data_model.add_model(pretrained_model_data_local_path, PRETRAINED_MODEL_PATH_1)
# Deploy model to an endpoint
multi_data_model.deploy(1, cpu_instance_type, endpoint_name=endpoint_name)
time.sleep(30)
# Add model after deploy
multi_data_model.add_model(pretrained_model_data_local_path, PRETRAINED_MODEL_PATH_2)

Expand Down