[pull] master from cube-js:master #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Fixing an unexpected issue with treating null as a null string. I figured out this issue while benchmarking the cache store queue. Previously, it could lead to an issue in the production environment while someone moves between cube store versions or has an error while updating the queue_item's extra field.
* add @types/node-dijkstra * some ramda fixes * more types in base member classes * more types * more types and EvaluatedCube type!! * more types * more types in CubeSymbols * more types in CubeSymbols * fix types in QueryOrchestrator * more types in CubeSymbols & Evaluator * fix types in ScaffoldingSchema * move JoinGraph to ts * more types in BaseQuery * fix * fix
…ed (#9712) The generic-pool package provides typings itself. Mixing types from the package and definitely typed is a bad idea :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )