Skip to content

[pull] master from cube-js:master #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ function stringifyMemberSql(sql?: () => string) {
}

const sqlStr = sql.toString();
return sqlStr.substring(sqlStr.indexOf('=>') + 3);
return sqlStr.substring(sqlStr.indexOf('=>') + 2).trim();
}

type MemberPath = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,37 @@ describe('transformMetaExtended helpers', () => {
expect(handledCube).toHaveProperty('dimensions');
});

test('transformCube - extends field preservation', () => {
const mockCubeDefinitions = {
BaseCube: { extends: () => 'BaseCube' },
ExtendedCube: { extends: () => 'ExtendedCube' },
AnotherCube: { extends: () => 'AnotherCube' },
TestCube: { extends: () => 'TestCube' },
SampleCube: { extends: () => 'SampleCube' }
};

const mockCubes = [
{ name: 'BaseCube' },
{ name: 'ExtendedCube' },
{ name: 'AnotherCube' },
{ name: 'TestCube' },
{ name: 'SampleCube' }
];

mockCubes.forEach(cube => {
const transformedCube = transformCube(cube, mockCubeDefinitions);
expect(transformedCube).toBeDefined();
expect(transformedCube.extends).toBe(`'${cube.name}'`);
});

// Specific test cases to verify first letter preservation
const baseCube = transformCube({ name: 'BaseCube' }, mockCubeDefinitions);
expect(baseCube.extends).toBe('\'BaseCube\'');

const extendedCube = transformCube({ name: 'ExtendedCube' }, mockCubeDefinitions);
expect(extendedCube.extends).toBe('\'ExtendedCube\'');
});

test('transformDimension', () => {
const handledDimension = transformDimension(MOCK_USERS_CUBE.dimensions.id, MOCK_USERS_CUBE);
expect(handledDimension).toBeDefined();
Expand Down
Loading