[pull] canary from vercel:canary #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
The stale bot comment says 2 years even though its 1.5 years (or 545 days to be precise). The exact amount of time is not as important in this message so we can remove it to avoid drift between the message and actual stale time.
- A Next.js starter app using [Prisma Postgres](https://www.prisma.io/postgres) and Prisma ORM This PR adds a new example demonstrating how to integrate Prisma ORM with a Next.js application. The example includes: - Setup instructions for Prisma Postgres - Example models and queries - Basic CRUD operations using Prisma --------- Co-authored-by: Nikolas <[email protected]> Co-authored-by: Alex Martin <[email protected]> Co-authored-by: JJ Kasper <[email protected]>
When running the following test isolated, and not as part of the full test suite, the owner stacks for async I/O errors were missing the top-most stack frame that's pointing at the `fetch` call. ``` pnpm test-dev test/e2e/app-dir/dynamic-io-errors/dynamic-io-errors.test.ts -t "should show a collapsed redbox with two errors" ``` The same could be reproduced with `pnpm next dev test/e2e/app-dir/dynamic-io-errors/fixtures/default` at http://localhost:3000/dynamic-root, unless http://localhost:3000/static was visited first. The likely reason for that is that React's async I/O tracking was recently optimized for performance reasons in facebook/react#33736 and facebook/react#33737. We can help React a bit with the tracking by explicitly awaiting our `makeHangingPromise` calls. With this fix, the case from above reliably works in isolation.
#81096) Fixes #64910 This PR resolves an issue where a client-side navigation to the root page fails when both `basePath` and `middleware` are active. This is caused by an incorrect redirect loop on the `/_next/data` request. The sequence of events is as follows: 1. Next.js enforces its `trailingSlash: false` policy by adding an internal redirect from `{basePath}/` to `{basePath}`. 2. For middleware to be invoked correctly, a data request for the root page is normalized to `/`. 3. The path is then re-joined with the `basePath` using `path.posix.join(config.basePath, '/')`, which incorrectly results in `{basePath}/`. 4. This malformed path triggers the redirect from step 1, causing the data fetch to fail with a 308 status code and resulting in empty `pageProps`. This fix isolates the root path (`/`) during path normalization to prevent an extra trailing slash from being added. By ensuring the path resolves to `{basePath}` instead of `{basePath}/`, the redirect loop is avoided. The change correctly handles the root path while leaving the logic for all other paths untouched. --------- Co-authored-by: JJ Kasper <[email protected]>
This auto-generated PR updates the development integration test manifest used when testing Rspack.
This auto-generated PR updates the production integration test manifest used when testing Rspack.
This ensures if using NextServer or a custom-server directly we honor the custom config passed in correctly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )