Tags: codingnninja/react-testing-library
Tags
fix(TS): make container optional in RenderOptions (testing-library#253) **What**: TS: make container optional in RenderOptions <!-- Why are these changes necessary? --> **Why**: Particularly useful if you're making a custom render with custom options. If you extend the type and call your custom render without the container but with the other options then you get a false error. <!-- How were these changes implemented? --> **How**: `?` <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [ ] Documentation N/A - [ ] Tests N/A - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table N/A <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
fix: update dom-testing-library dependency (testing-library#240)
feat: add flushEffects to prepare for hooks (testing-library#223)
fix: remove wait-for-expect from dependencies (testing-library#205) **What**: Remove unused dependency from `package.json` **Why**: This package is not used here directly. Dom-testing-library uses it though and declares it there already: https://github.com/kentcdodds/dom-testing-library/blob/master/package.json#L43 On the other hand, in case if dom-testing-library would use a new major version of the dependency, there will be unwanted package duplication, because this line will stay. Packages should not declare dependencies on other packages, that they actually do not use. **Checklist**: - (N/A) Documentation - (N/A) Tests - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - (N/A) Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
feat: add `asFragment` return value from `render` (testing-library#192) <!-- Thanks for your interest in the project. Bugs filed and PRs submitted are appreciated! Please make sure that you are familiar with and follow the Code of Conduct for this project (found in the CODE_OF_CONDUCT.md file). Also, please make sure you're familiar with and follow the instructions in the contributing guidelines (found in the CONTRIBUTING.md file). If you're new to contributing to open source projects, you might find this free video course helpful: http://kcd.im/pull-request Please fill out the information below to expedite the review and (hopefully) merge of your pull request! --> <!-- What changes are being made? (What feature/bug is being fixed here?) --> **What**: Adds the possibility to get a `DocumentFragment` version of the rendered component. <!-- Why are these changes necessary? --> **Why**: I have a test of a connected redux component, and I want to snapshot the diff between them after dispatching an action. Since `container` is a live binding, its `innerHTML` changes, meaning comparison becomes meaningless. An extra advantage is IMO that you don't need to do `firstChild` on snapshots, as having the `Fragment` wrapper makes sense. At least in my mind 🙂 <!-- How were these changes implemented? --> **How**: By upgrading `kcd-scripts` to a version with Jest 23, and adding a dependency on `JSDOM` which matches the one found in Jest (to not rely on dependency hoisting). <!-- Have you done all of these things? --> **Checklist**: <!-- add "N/A" to the end of each line that's irrelevant to your changes --> <!-- to check an item, place an "x" in the box like so: "- [x] Documentation" --> - [x] Documentation - [x] Tests - [x] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? --> - [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions --> <!-- feel free to add additional comments -->
PreviousNext