Fix(sidebar): remove items attribute from li element #404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Just found this little issue, it is happening right now in your demo:
https://coreui.io/demos/react/4.0/free/#/dashboard
In sidebar navigation, all
li
elements with nested lists look like this (they have extraitems
attribute)I wrote a test for this case, it doesn't pass in the current master branch but passes with the fix.
I need to test for attributes that are not visible to user, that's why I did as it said here:
https://testing-library.com/docs/queries/about/#manual-queries
But I was forced to ignore some linter warnings in the test file because it was complaining
Not the best decision, sorry, but I really wanted to add some tests!
What do you think? What can I do - rewrite the test, delete the test, delete the whole MR?...