Mobile sidebar link click should close the sidebar #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mobile user clicks a link in the sidebar, it should close that sidebar for mobile users. The reason is that the "default" mobile experience ought to be menu-less or content will flow off the screen.
|
Hi, in your solution the sidebar is only closing if the user press exactly on the link, but not if the user clicks on the nav-item. Here your method inside the SidebarNavItem.vue (Version 1.0.6) Sorry, currently I don't know how to create a pull request https://gist.github.com/PewQuadrat/a953b6bf3b3bd8715223594717b02aaf |
woothu
pushed a commit
that referenced
this pull request
Nov 23, 2018
Mobile sidebar link click should close the sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mobile user clicks a link in the sidebar, it should close that sidebar for mobile users.
The reason is that the "default" mobile experience ought to be menu-less or content will flow off the screen.