Fix: CButton variant styling when undefined #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix where the CButton defaults to 'btn-undefined' when the variant is not declared.
Example, pre-PR with no declared
variant
attribute on a CButton component:New Behavior:
variant
attribute is undeclared, it will not add'btn-undefined'
like it had been doing.color
andvariant
attributes are declared, it will'btn-{variant}-{color}'
like it currently does.color
attribute is undeclared and thevariant
attribute is declared, it will'btn-{variant}'
like it currently does.