Skip to content

feat: add solutions to lc problem: No.1462 #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat: add solutions to lc problem: No.1462 #1551

merged 2 commits into from
Aug 31, 2023

Conversation

yanglbme
Copy link
Member

No.1462.Course Schedule IV

@github-actions
Copy link
Contributor

🤭 感谢你的提交,请检查你的改动是否符合以下项目规范。

1. 格式化

我们项目中各种编程语言代码(包括文档)所采用的格式化工具不同,提交 pr 之前必须确保代码、文档正确格式化。

  • .{md,js,ts,php,sql} 采用 prettier
  • .{c,cpp,java} 采用 clang-format
  • .{py} 采用 black
  • .{go} 采用 gofmt
  • 其它待完善

2. Git 提交信息

我们项目遵循 AngularJS Git Commit Message Conventions 规范,我们希望你的提交信息尽可能与项目保持一致。

  • 新增或修改题解:feat: add/update solution(s) to lc problem(s): No.xxxx
  • 修复错误:fix: xxxx
  • 日常维护:chore: xxx

3. 其它补充

新增题解及代码时,需要创建 Solution.xxx 源代码文件(如果已存在,请确认算法是否更优,是则覆盖已有算法代码),同时,需要在 README.md 以及 README_EN.md 中添加对应的代码片段(英文文件中不要出现中文注释)

另外,编码风格(比如变量、函数的命名),尽量跟项目已有代码保持一致。


🤭 Thank you for your contribution. Please check if your changes comply with the following project specifications.

1. Formatting

We use different formatting tools for various programming languages (including documentation) in our project. You must ensure that the code and documentation are correctly formatted before submitting a pr.

  • .{md,js,ts,php,sql} use prettier
  • .{c,cpp,java} use clang-format
  • .{py} use black
  • .{go} use gofmt
  • Others to be improved

2. Git Commit Message

Our project follows the AngularJS Git Commit Message Conventions. We hope that your submission information is as consistent as possible with the project.

  • Add or modify solutions: feat: add/update solution(s) to lc problem(s): No.xxxx
  • Fix errors: fix: xxxx
  • Routine maintenance: chore: xxx

3. Other notes

When adding solutions and code, you need to create a Solution.xxx source code file (if it already exists, please confirm whether the algorithm is better, if yes, overwrite the existing algorithm code), and at the same time, you need to add the corresponding code snippets in README.md and README_EN.md (do not have Chinese comments in the English file)

In addition, the coding style (such as the naming of variables and functions) should be as consistent as possible with the existing code in the project.

);
for (const [a, b] of prerequisites) {
f[a][b] = true;
}
Copy link
Member

@thinkasany thinkasany Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 这里简单的操作似乎可以用,forEach来
prerequisites.forEach(([i, j]) => f[i][j] = true);
  1. 顺便问一下,感觉这换行是不是有点太多了, prettierrc的规则是不是可以改一下

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antd中用的100,咱们项目没设置的话 默认80,感觉有时候吧,不是很清爽, 就是感觉这题上换行有点太多了。
image

换成百个字符的规则之后
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先改了代码,至于 prettier 的配置,可以后面提交 pr 来改。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你可以试试加上"printWidth": 100, npx prettier --write "**/*.{ts,md}"
感觉一百个字符还是挺合适的,作为对规则的讨论嘛,的确有的简洁的题目因为参数多变成很臃肿。

你的考虑是升级配置应该是 chore: Adjust prettier printWidth 类似的提交不要和更改题目的提交耦合么

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,这道题先提交。

后面修改格式配置后,会全局 reformat,放另一个 commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实可以改成 100,之前没注意到有这个配置

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那我来蹭一个chore: Adjust prettier printWidth 然后你再上面reformat

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实可以改成 100,之前没注意到有这个配置

这题换行换的太明显了 之前有的换行的确是因为行数比较长

@yanglbme yanglbme merged commit faa7af7 into main Aug 31, 2023
@yanglbme yanglbme deleted the dev branch August 31, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants