Skip to content

Make tables use all available space #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mnishiguchi
Copy link
Contributor

@mnishiguchi mnishiguchi commented Aug 29, 2021

This is a minor enhancement. Currently table widths depend on the max text length, which can lead to tables in different widths especially when the display is large. Just by specifying the 100% width, we can make them look consistent.

.search-table {
  width: 100%;
}

Elixir Circuits website table width Screen Recording 2021-08-29 at 11 56 39 AM

I think alternatively we could set max-width to a certain value.

.search-table {
    max-width: 75rem;
}

max-width Screen Recording 2021-08-29 at 12 11 42 PM

@fhunleth fhunleth merged commit 6067df9 into elixir-circuits:master Aug 29, 2021
@fhunleth
Copy link
Contributor

Looks good to me. Thanks!

@mnishiguchi mnishiguchi deleted the mnishiguchi/table-width branch August 29, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants