Adding oneOf with discriminator property support

[sjoerdmulder]

First of all awesome project!

Currently it seems there is no support for discriminators from the V3 spec in the generator.

This PR adds some preliminary support so that instead of:

export type ModelCircle = {
    kind: string;
    radius?: number;
}
export type ModelSquare = {
    kind: string;
    sideLength?: number;
}
export type Shape = Circle | Square;

It generates (not the the kind: string is replaced)

export type ModelCircle = {
    kind: 'circle';
    radius?: number;
}
export type ModelSquare = {
    kind: 'square';
    sideLength?: number;
}
export type Shape = Circle | Square;

Added some tests as well, let me know what you think!

[codecov]

Codecov Report

Merging #645 (517408d) into master (19c171b) will increase coverage by 0.08%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   90.57%   90.65%   +0.08%     
==========================================
  Files         108      109       +1     
  Lines        1528     1552      +24     
  Branches      298      304       +6     
==========================================
+ Hits         1384     1407      +23     
- Misses        144      145       +1     

Impacted Files	Coverage Δ
src/utils/discriminator.ts	95.00% <95.00%> (ø)
src/openApi/v3/parser/getModel.ts	100.00% <100.00%> (ø)
src/openApi/v3/parser/getModelProperties.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c171b...517408d. Read the comment docs.

[ferdikoomen]

@sjoerdmulder Sorry for the late reply, I was away due to a covid infection. Thanks for the PR, looks good! I will do some quick tests and if it looks good, then will merge it today

[sjoerdmulder]

I hope you are feeling better! FYI the code that the PR generates is already used by our company internally in production with around a dozen different polymorphic types and works without problem ;-) Op di 27 apr. 2021 13:05 schreef Ferdi Koomen ***@***.***>:

…

@sjoerdmulder <https://github.com/sjoerdmulder> Sorry for the late reply, I was away due to a covid infection. Thanks for the PR, looks good! I will do some quick tests and if it looks good, then will merge it today — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#645 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABZRYN2I4H27MAO55USDPLTK2K7LANCNFSM42SQ55XA> .