Skip to content

Build 0.9.3/discriminator #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

markygab
Copy link

@markygab markygab commented Sep 6, 2021

No description provided.

richgoldmd and others added 30 commits September 22, 2020 13:43
# Conflicts:
#	src/templates/core/OpenAPI.hbs
#	src/templates/core/Result.ts
#	src/templates/core/request.ts
#	src/templates/core/requestUsingFetch.ts
#	src/templates/core/requestUsingXHR.ts
#	test/__snapshots__/index.spec.js.snap
Pull in original PR + dist
@lgtm-com
Copy link

lgtm-com bot commented Sep 6, 2021

This pull request introduces 4 alerts and fixes 6 when merging 8f6f317 into 715ddce - view on LGTM.com

new alerts:

  • 4 for Unneeded defensive code

fixed alerts:

  • 6 for Polynomial regular expression used on uncontrolled data

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #825 (715ddce) into master (19c171b) will not change coverage.
The diff coverage is n/a.

❗ Current head 715ddce differs from pull request most recent head 8f6f317. Consider uploading reports for the commit 8f6f317 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files         108      108           
  Lines        1528     1528           
  Branches      298      298           
=======================================
  Hits         1384     1384           
  Misses        144      144           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c171b...8f6f317. Read the comment docs.

@ferdikoomen
Copy link
Owner

Closing this PR because it's a combination of different PR's. Will review #741 and merge

@ferdikoomen ferdikoomen closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants