Code Quality: Improved Omnibar 14 #17248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
force-pushed
the
5bfa/CQ-OmnibarSearch
branch
from
1fa5953 to
dba4123
Compare
…ed the mode button's height
0x5bfa
changed the title
yaira2
reviewed
Jul 4, 2025
| if (ContentPageContext.SelectedItems.Count == 1 && ContentPageContext.SelectedItem is not null && !ContentPageContext.SelectedItem.IsFolder) | ||
| { | ||
| var dispatcherQueue = Microsoft.UI.Dispatching.DispatcherQueue.GetForCurrentThread(); | ||
|
|
||
| dispatcherQueue.TryEnqueue(() => |
There was a problem hiding this comment.
I found that DispatcherQueue is required for actions to work properly. Unfortunately, we can't do any further testing in this area right now because the experimental API doesn't seem to work in the latest Insider build.
There was a problem hiding this comment.
Please look at the L439 of NavigationToolbar.xaml.cs, I've wrapped the whole method with it.
There was a problem hiding this comment.
It looks like it's missing from the Omnibar_TextChanged event. To prevent this from being missed in the future, it would be safer to revert this change.
yaira2
force-pushed
the
main
branch
2 times, most recently
from
42c8207 to
4c7493f
Compare
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes