Skip to content

Code Quality: Prevent crash when sync root info is null #17318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Observed crash reported in FILES-APP-3FZ due to NullReferenceException.
  2. Verified that the crash occurs when syncRootInfo is null in GetSyncRootInformationForFolder for non-sync-root drives.
  3. Implemented a null check for syncRootInfo.
  4. Confirmed that the null check prevents the crash when syncRootInfo is null.
  5. Tested with both sync-root and non-sync-root drives to ensure no regressions.

@yaira2 yaira2 changed the title Fix: Prevent crash when sync root info is null Code Quality: Prevent crash when sync root info is null Jul 25, 2025
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 25, 2025
@yaira2 yaira2 marked this pull request as ready for review July 25, 2025 02:34
@yaira2 yaira2 merged commit 2f5ee47 into main Jul 25, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/fix/sync-root-null-check branch July 25, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants