Skip to content

Feature: Added Digital Signatures tab to the properties window #17334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Download some .exes (or any other signed file)
  2. Open their properties
  3. Open the Digital Signatures tab and check you see the right data
  4. Click on the Details button
DigitalSignatures.mp4

@ferrariofilippo ferrariofilippo marked this pull request as draft July 27, 2025 20:46
@ferrariofilippo ferrariofilippo marked this pull request as ready for review July 27, 2025 20:51
@yaira2 yaira2 self-requested a review July 27, 2025 22:42
@ferrariofilippo
Copy link
Contributor Author

BTW I think we should reference this project (https://github.com/leeqwind/PESignAnalyzer/) somewhere, since the business logic is theirs translated to C#

@yaira2
Copy link
Member

yaira2 commented Jul 29, 2025

We have space on the about page 👍

Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There're some tiny improvements that can be made but this is already working very well. I can take care of unmanaged stuff.

Behavior wise, LGTM.

@yaira2 yaira2 changed the title Feature: Add Digital Signatures tab to the properties window Feature: Added Digital Signatures tab to the properties window Jul 30, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jul 30, 2025
@yaira2 yaira2 merged commit ff566bb into files-community:main Jul 30, 2025
6 checks passed
@ferrariofilippo ferrariofilippo deleted the feature_digital_signatures_2 branch July 31, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add digital signatures tab to properties window
5 participants