-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Feature: Added Digital Signatures
tab to the properties window
#17334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added Digital Signatures
tab to the properties window
#17334
Conversation
Signed-off-by: Filippo Ferrario <[email protected]>
BTW I think we should reference this project (https://github.com/leeqwind/PESignAnalyzer/) somewhere, since the business logic is theirs translated to C# |
We have space on the about page 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There're some tiny improvements that can be made but this is already working very well. I can take care of unmanaged stuff.
Behavior wise, LGTM.
Signed-off-by: Filippo Ferrario <[email protected]>
src/Files.App/Data/Factories/PropertiesNavigationViewItemFactory.cs
Outdated
Show resolved
Hide resolved
Digital Signatures
tab to the properties windowDigital Signatures
tab to the properties window
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
.exe
s (or any other signed file)Digital Signatures
tab and check you see the right dataDetails
buttonDigitalSignatures.mp4