Feature: Add Everything search & folder size calculation #17336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Everything search engine integration as an alternative to Windows Search - Implement fast folder size calculation using Everything's indexing - Add settings UI to switch between Windows Search and Everything - Show warning if Everything is not installed with download link - Automatically use Everything for folder sizes when selected as search engine - Add safeguards for large directories to prevent memory issues - Support architecture-aware DLL loading (Everything32.dll/Everything64.dll) - Implement graceful fallback to Windows Search when Everything is unavailable - Add periodic availability checks (every 30 seconds) to detect Everything status - Remove separate toggle for Everything folder sizes - automatic when Everything is enabled 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Josh65-2201
reviewed
Jul 28, 2025
src/Files.App/Utils/Storage/Search/EverythingSearchEngineService.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
- Implement EverythingSdk3Service for Everything 1.5 integration - Add direct folder size query using Everything3_GetFolderSizeFromFilenameW() - Automatic detection and fallback: SDK3 -> SDK2 -> Windows Search - Update EverythingSearchService to try SDK3 first - Update EverythingSizeProvider to use SDK3 when available - Add proper error handling for missing SDK3 DLLs - Add documentation about SDK3 requirements - SDK3 provides significant performance improvements for folder size calculations Note: SDK3 DLLs must be obtained separately from https://github.com/voidtools/everything_sdk3 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Fixes CS0117 compilation error - Toast notification method was not implemented in AppToastNotificationHelper 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Run all folder size calculations on background threads - Add semaphore to limit concurrent calculations to 3 - Add timeout (2s) for SDK3 folder size queries - Fire and forget size calculations during enumeration - Return cached sizes immediately without blocking - Properly dispose resources (semaphore and SDK3 service) This prevents the UI from freezing when navigating folders with Everything folder size calculation enabled. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Josh65-2201
reviewed
Jul 28, 2025
There was a problem hiding this comment.
I noticed the log gets spammed and seems unnecessary
2025-07-28 20:05:53.4383|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:53.4520|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\DRM removed (0 files)
2025-07-28 20:05:54.0583|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:54.0761|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Program Files (0 files)
2025-07-28 20:05:54.0871|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:54.1074|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Path of Titans (0 files)
2025-07-28 20:05:54.1578|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:54.1756|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Steam (0 files)
2025-07-28 20:05:54.3140|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:54.3279|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\Unity Editors (0 files)
2025-07-28 20:05:55.3815|Information|[Everything SDK3] SDK3 DLL not found - Everything 1.5 not installed
2025-07-28 20:05:55.3968|Information|[EverythingSizeProvider SDK2] Calculated 0 bytes for G:\WindowsApps (0 files)
|
There a stack overflow crash when in some folders and calculate folder size is enabled using Everything 1.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-07-28.10-22-09.mp4