Skip to content

Fix: Fixed issue where delete key wouldn't work after removing item from selection #17348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Notes
It seems the issue is caused by the checkbox, which when focused handles all Key-related events.
For some reason I don't understand, the bug affects only Deselection and not Selection
The code below removes the focus from the checkbox once its state is updated

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Open a folder with multiple files (test different layouts)
  2. Select some of them
  3. Deselect one clicking on the checkbox
  4. Hit the Del key and see that the modal pops-up
  5. Repeat 3 and 4 as many times as you wish
Selection.mp4

@yaira2 yaira2 added the changes requested Changes are needed for this pull request label Jul 29, 2025
@yaira2 yaira2 changed the title Fix: Delete key doesn't work when removing selection Fix: Fixed issue where delete key wouldn't work after removing item from selection Jul 29, 2025
yaira2
yaira2 previously approved these changes Jul 29, 2025
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jul 29, 2025
@yaira2 yaira2 merged commit f8b3725 into files-community:main Jul 29, 2025
6 checks passed
@yaira2 yaira2 changed the title Fix: Fixed issue where delete key wouldn't work after removing item from selection Fix: Fixed issue where delete key wouldn't work after removing item from selection Jul 29, 2025
@ferrariofilippo ferrariofilippo deleted the fix_delete_key_after_deselection branch July 29, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Delete key doesn't work when removing one item from selection
2 participants