Skip to content

Fix: Handle exceptions when opening files from IFileActivatedEventArgs #17356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. The issue was that: COMException from IFileActivatedEventArgs.get_Files occurs when accessing activated files, likely due to invalid or inaccessible file system items.
  2. Added a try-catch block to handle exceptions that may occur when opening files from IFileActivatedEventArgs.
  3. Logged the exception if it occurs.
  4. Navigated to the MainPage if an exception occurs and the rootFrame is null, SplashScreenPage, or no AppInstances exist.

This fix was generated by Seer in Sentry, triggered by Yair. 👁️ Run ID: 502189

Not quite right? Click here to continue debugging with Seer.

Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a little additional code, but looks good to me.

Co-authored-by: hishitetsu <[email protected]>
Signed-off-by: Yair <[email protected]>
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 31, 2025
@yaira2 yaira2 marked this pull request as ready for review July 31, 2025 14:30
@yaira2 yaira2 merged commit 223ecce into main Jul 31, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/fix/file-activation-exception branch July 31, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants