Skip to content

Code Quality: Remove setting item template and source in Omnibar #17375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Verified that the popup opening no longer fails after the changes.
  2. Confirmed that the Omnibar control functions as expected without the item template and source being set for the suggestions list view based on CurrentSelectedMode.
  3. Ensured no regressions in Omnibar functionality.

@yaira2 yaira2 changed the title Refactor: Remove setting item template and source in Omnibar Code Quality: Remove setting item template and source in Omnibar Jul 31, 2025
@yaira2 yaira2 requested a review from 0x5bfa July 31, 2025 01:11
@yaira2 yaira2 marked this pull request as ready for review July 31, 2025 01:11
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Jul 31, 2025
@yaira2 yaira2 merged commit 9a2237f into main Jul 31, 2025
9 checks passed
@yaira2 yaira2 deleted the seer/remove-omnibar-item-template branch July 31, 2025 01:41
yaira2 added a commit that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant