Feature: Reword 'add pane' to 'split pane' #17387
Merged
+97
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fyi @mdtauk and @SilverGreen93 |
There was a problem hiding this comment.
Pull Request Overview
This PR renames "add pane" terminology to "split pane" throughout the codebase and swaps the default behavior so that Vertical arrangement is the default instead of Horizontal. The changes improve terminology clarity by using "split" instead of "add" and reorder menu items to prioritize vertical splits.
- Renamed all instances of "add pane" to "split pane" in UI text and command names
- Changed default pane arrangement from Horizontal to Vertical
- Reorganized settings UI to move dual pane options outside of an expander
- Reordered menu items to show vertical split first, then horizontal split
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ShellPanesPage.xaml.cs | Swapped Horizontal/Vertical arrangement logic throughout pane management |
| GeneralPage.xaml | Restructured dual pane settings UI and updated terminology |
| GeneralViewModel.cs | Reordered pane arrangement types to prioritize Vertical |
| TabBar.xaml | Updated menu structure and command references for split pane actions |
| Resources.resw | Updated all text resources from "add pane" to "split pane" terminology |
| GeneralSettingsService.cs | Changed default arrangement from Horizontal to Vertical |
| ICommandManager.cs | Renamed command properties to use "SplitPane" terminology |
| CommandManager.cs | Updated command mappings and action references |
| CommandCodes.cs | Renamed enum values to match new terminology |
| SplitPaneVerticallyAction.cs | Updated labels and icons to match new terminology |
| SplitPaneHorizontallyAction.cs | Renamed class and updated all references to use "SplitPane" terminology |
| ArrangePanesVerticallyAction.cs | Fixed icon reference to use correct themed icon |
| ArrangePanesHorizontallyAction.cs | Fixed icon reference to use correct themed icon |
SilverGreen93
approved these changes
Jul 31, 2025
yaira2
added
ready to merge
|
What fills the content of the new pane that is added? |
It's always the Home page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.