Skip to content

Feature: Added simple header to search results #17399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2025
Merged

Feature: Added simple header to search results #17399

merged 6 commits into from
Aug 4, 2025

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Aug 4, 2025

image

@yaira2 yaira2 requested a review from Copilot August 4, 2025 14:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a search header to display context when viewing search results in the application. The header includes a search icon and displays "Search results for {query}" text.

  • Adds a visual search results header with icon and query text
  • Modifies grid layout to accommodate the new header above the filter header
  • Implements UI binding properties and localization support for the search header

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ModernShellPage.xaml Adds new row definition and search header UI with grid layout adjustments
ShellViewModel.cs Implements search header properties and bindings with lifecycle management
Resources.resw Adds localized string resource for search results header text
UIHelpers.cs Adds helper method to load search icon from system resources
Constants.cs Defines search icon constant for system resource extraction
Comments suppressed due to low confidence (1)

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Aug 4, 2025
@yaira2 yaira2 merged commit 427a9b2 into main Aug 4, 2025
7 checks passed
@yaira2 yaira2 deleted the ya/SearchHeader branch August 4, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant